Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested bean instance supplier invocation does not retain previous factory method #33185

Closed
github-actions bot opened this issue Jul 10, 2024 · 1 comment
Closed

Nested bean instance supplier invocation does not retain previous factory method #33185

github-actions bot opened this issue Jul 10, 2024 · 1 comment
Assignees
@snicoll
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
6.0.23

Comments

@github-actions
Copy link
Contributor

Backport of gh-33180
@github-actions github-actions bot added in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Jul 10, 2024
@github-actions github-actions bot added this to the 6.0.23 milestone Jul 10, 2024
@snicoll snicoll self-assigned this Jul 10, 2024
snicoll added a commit that referenced this issue Jul 10, 2024
@snicoll
Retain previous factory method in case of nested invocation with AOT
be7029c 
This commit harmonizes the invocation of a bean supplier with what
SimpleInstantiationStrategy does. Previously, the current factory method
was set to `null` once the invocation completes. This did not take
into account recursive scenarios where an instance supplier triggers
another instance supplier.

For consistency, the thread local is removed now if we attempt to set
the current method to null. SimpleInstantiationStrategy itself uses
the shortcut to align the code as much as possible.

Closes gh-33185
@github-actions GitHub Actions
Copy link
Contributor Author

Fixed via be7029c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
6.0.23
Development

No branches or pull requests
1 participant
@snicoll