Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow encoding to be set with a Charset in FreeMarker support #33102

Closed
sbrannen opened this issue Jun 26, 2024 · 0 comments
Closed

Allow encoding to be set with a Charset in FreeMarker support #33102

sbrannen opened this issue Jun 26, 2024 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.2.0-M5

Comments

@sbrannen
Copy link
Member

Overview

While working on #33071, we noticed that our FreeMarker support still requires the encoding be supplied as a String; whereas, it would be convenient for users to be able to supply the encoding via a Charset -- for example, via constants defined in StandardCharsets.

This applies to the FreeMarker support in spring-context-support, spring-webmvc, and spring-webflux.

Related Issues
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Jun 26, 2024
@sbrannen sbrannen added this to the 6.2.0-M5 milestone Jun 26, 2024
@sbrannen sbrannen self-assigned this Jun 26, 2024
sbrannen added a commit that referenced this issue Jun 26, 2024
@sbrannen
Polish naming for Charset setters in FreeMarker support
95887c8 
See gh-33102
@sbrannen sbrannen mentioned this issue Jun 29, 2024
Closed
snicoll added a commit that referenced this issue Jul 4, 2024
@snicoll
Fix broken Javadoc reference
b0807d8 
See gh-33102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-M5
Development

No branches or pull requests
1 participant
@sbrannen