Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Websocket - JettyWebsocketHandlerAdapter copyByteBuffer fills Buffer with zeros #31857

Closed
forsti0506 opened this issue Dec 18, 2023 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@forsti0506
Copy link

Hi Team,

Short Question from my side regarding

In the last change the initialization of the ByteBuffer changed from using the limit (Standard BinaryMessage Constructor using limit) to using the max capacity which leads to a buffer which is filled up with zeros until his capacity is reached (ed172d6#diff-43448f6e16d92d0df476c611919c95839ad9f2874d149cf939d8f91a2824b5f3)

Is there any reason to do that and not changing the mentioned Line 121 to using limit again? In our case that leads to some troubles with protobuf from google which expects that a buffer ends with exact 1 "0"!

Thanks a lot for a discussion in advance!

Best regards,

Martin

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 18, 2023
@poutsma poutsma self-assigned this Dec 18, 2023
@poutsma poutsma added type: bug A general bug in: web Issues in web modules (web, webmvc, webflux, websocket) labels Dec 18, 2023
@poutsma poutsma added this to the 6.1.3 milestone Dec 18, 2023
@poutsma poutsma removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants