Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit XML schema handling for consistent local vs external resolution #22504

Closed
jhoeller opened this issue Mar 4, 2019 · 0 comments
Closed

Revisit XML schema handling for consistent local vs external resolution #22504

jhoeller opened this issue Mar 4, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.1.6

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Mar 4, 2019 •
edited
Loading

Following up on #18077, we could allow further variants of Spring schema declarations - e.g. with https, despite http being the canonical identifier for XML schemas - that still resolve against locally shipped xsd files (as defined in spring.schemas with canonical http identifiers). At the same time, we could consistently resolve external references via https even if the declaration uses the canonical http identifiers, separating the common XML identifier format from the recommended wire protocol.
@jhoeller jhoeller self-assigned this Mar 4, 2019
@jhoeller jhoeller added this to the 5.1.6 milestone Mar 4, 2019
@jhoeller jhoeller added the type: enhancement A general enhancement label Mar 4, 2019
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Mar 5, 2019
@jhoeller jhoeller changed the title Revisit XML schema handling for lenient local resolution Revisit XML schema handling for consistent local vs external resolution Mar 6, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.0.x labels Mar 6, 2019
Closed
Closed
jhoeller added a commit that referenced this issue Mar 6, 2019
@jhoeller
Consistent local vs external resolution of https schema references
7b97ec3 
Closes gh-22504
jhoeller added a commit that referenced this issue Mar 6, 2019
@jhoeller
Local https URL resolution attempt with fallback to parser's default
9cc8622 
See gh-22504
jhoeller added a commit that referenced this issue Mar 6, 2019
@jhoeller
Local https URL resolution attempt with fallback to parser's default
458f75f 
See gh-22504
jhoeller added a commit that referenced this issue Mar 6, 2019
@jhoeller
Consistent local vs external resolution of https schema references
2b5434e 
Closes gh-22504
sbrannen pushed a commit to sbrannen/spring-framework that referenced this issue Mar 31, 2019
@jhoeller @sbrannen
Consistent local vs external resolution of https schema references
9543b9c 
Co-Authored-By: Sam Brannen <sbrannen@pivotal.io>

See spring-projectsgh-22504
sbrannen pushed a commit to sbrannen/spring-framework that referenced this issue Mar 31, 2019
@jhoeller @sbrannen
Consistent local vs external resolution of https schema references
2a268f2 
Co-Authored-By: Sam Brannen <sbrannen@pivotal.io>

See spring-projectsgh-22504
@yoshikawaa yoshikawaa mentioned this issue Apr 5, 2019
Closed
6 tasks
This was referenced Apr 10, 2019
Closed
Closed
Closed
@bthabukar bthabukar mentioned this issue Nov 6, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.6
Development

No branches or pull requests
3 participants
@sbrannen @jhoeller @spring-projects-issues