Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Lifecycle.stop() for already started beans on failed refresh [SPR-15468] #20028

Closed
spring-projects-issues opened this issue Apr 20, 2017 · 0 comments
Closed

Call Lifecycle.stop() for already started beans on failed refresh [SPR-15468] #20028

spring-projects-issues opened this issue Apr 20, 2017 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.1.0-RC1

Comments

@spring-projects-issues
Copy link
Collaborator

Bill Chen opened SPR-15468 and commented

Currently, Lifecycle.stop() is documented not to be called if refresh failed. However, this makes lifecycle process really asymmetrical (especially when refresh failed due to an exception thrown from Lifecycle.start()).

Can an option be added to call Lifecycle.stop() on already started beans?

No further details from SPR-15468
@spring-projects-issues spring-projects-issues added status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) and removed type: enhancement A general enhancement labels Jan 11, 2019
@jhoeller jhoeller changed the title Option to call Lifecycle.stop() on failed refresh [SPR-15468] Call Lifecycle.stop() for already started beans on failed refresh [SPR-15468] Sep 19, 2023
@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 19, 2023
@jhoeller jhoeller self-assigned this Sep 19, 2023
@jhoeller jhoeller added this to the 6.1.0-RC1 milestone Sep 19, 2023
@snicoll snicoll mentioned this issue Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-RC1
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues