Upgrade HttpComponentsHttpInvokerRequestExecutor to require Apache HttpComponents 4.3 [SPR-11113]

[spring-projects-issues]

Phil Webb opened SPR-11113 and commented

We didn't want to bump the minimum version up to the recently released HttpComponents 4.3 for Spring 4.0 quite yet, at least not for HttpComponentsHttpInvokerRequestExecutor - rather just for async support in other places.

However, due to plenty of deprecations, we should raise the bar in Spring 4.1 then, once HttpComponents 4.3 has been out for half a year at least. (Note: We raised to HttpComponents 4.2 in Spring 3.2 after about the same time of availability.)

---

Affects: 4.0 GA

Issue Links:

• org.apache.http.impl.client.InternalHttpClient.getParams() throws UnsupportedOperationException [SPR-12530] #17135 org.apache.http.impl.client.InternalHttpClient.getParams() throws UnsupportedOperationException ("duplicates")
• Inconsistent support for RequestCallback in HttpComponentsClientHttpRequestFactory [SPR-11981] #16597 Inconsistent support for RequestCallback in HttpComponentsClientHttpRequestFactory
• Require Jackson 2.1+, Quartz 2.1.4+, EhCache 2.5+ [SPR-11262] #15887 Require Jackson 2.1+, Quartz 2.1.4+, EhCache 2.5+
• Apache HttpComponents 4.3 required at runtime but not listed in migration guide [SPR-11383] #16010 Apache HttpComponents 4.3 required at runtime but not listed in migration guide
• When using HttpComponentsClientHttpRequestFactory, setting a proxy through RequestConfig should not be ignored [SPR-12335] #16940 When using HttpComponentsClientHttpRequestFactory, setting a proxy through RequestConfig should not be ignored
• Configured RequestConfig in HttpClient gets overwritten by default [SPR-12540] #17144 Configured RequestConfig in HttpClient gets overwritten by default

0 votes, 5 watchers

[spring-projects-issues]

Stéphane Nicoll commented

#17135 actually revealed that our support was broken with 4.3 so we should probably review the current patch and apply it for 4.1 still.

[spring-projects-issues]

Stéphane Nicoll commented

HttpComponents 4.3 is now required and has been updated to handle both the new CloseableHttpClient and the (now) deprecated HttpClient. In both cases, socket and read timeout set on the executor instance takes precedence over values set on the HttpClient directly.

If you want the defaults of the current HttpClient to takes precedence you can override createRequestConfig as explained in the Javadoc.