TransactionAspectSupport should be aware of CallbackPreferringPlatformTransactionManager to better support WebSphere, more specifically REQUIRES_NEW and NOT_SUPPORTED propagation [SPR-9268]

[spring-projects-issues]

László Váradi opened SPR-9268 and commented

TransactionAspectSupport uses the "getTransaction" style for setting up transaction environment for the actual method. However, in this style transaction suspension is not supported by WebSphereUowTransactionManager, as it is said in the javadoc of it.

TransactionAspectSupport should be refactored to be able to handle CallbackPreferringPlatformTransactionManager transaction managers. However, the "execute" style needs refactoring in the AbstractTransactionAspect aspect, as this style can be supported only with around advice, but not with before + after advises.

---

Affects: 3.0.7

Attachments:

• callback-supporting-tx-aspects-sources.zip (2.90 kB)

0 votes, 6 watchers

[spring-projects-issues]

Prakash Rao commented

Is there any work around for this issue till it is fixed? We want to use aspectj mode of the transaction manager but this issue prevents us from switching to spring aop to a full blown aspectj solution.

[spring-projects-issues]

László Váradi commented

Hi!

We use this aspect (see attachment) instead of the spring original in our project.
Package and class names are refactored...

[spring-projects-issues]

Juergen Hoeller commented

As of 3.2.2, AbstractTransactionAspect got refactored into around advice, reusing former TransactionInterceptor code which now lives in slightly generalized form in TransactionAspectSupport. This change is somewhat along the lines of the attached aspect but using traditional AspectJ style instead of an @Aspect, and building on refactored code in TransactionAspectSupport.

Guys, it would be great if you could give this a try in one of the upcoming 3.2.2 snapshots (see http://repo.springsource.org/libs-snapshot-local/org/springframework/). You'd at least need to switch your spring-tx and spring-aspects modules to 3.2.2, but ideally you'd simply switch all your Spring modules to 3.2.2 since that's the only arrangement that we officially support.

Juergen

[spring-projects-issues]

Prakash Rao commented

I can confirm that this works for me.

[spring-projects-issues]

Vít Novák commented

Please note, that using around advice in an aspect that is widely used such as AbstractTransactionAspect can make stack traces very unclear.

Some time ago, we have switched another aspect from around to before + after just to get nice stack traces, after we ruined them with around advice. This may happen in poorly designed code, which is surely our case, but also when an advised service reuses its own advised methods. Now each call increases stack by 7 lines instead of 1 and 6 of them are quite cryptic for most developers (and also useless in most cases).

If there was a choice between before + after and around, I would prefer former one, just for this reason.

[spring-projects-issues]

Teun Hoogendoorn commented

The rewrite from "before + after" to "around" broke the reweave capability of @Transactional annotated classes (even with -Daspectj.overweaving=true).

I've tested with:

• Different Java versions (Java 6 and 7).
• Different versions of aspectj (1.6 to 1.7)
• Different Spring-instrument versions (spring-agent to spring-instrument)

The error I see in the log:

SEVERE: org/springframework/transaction/aspectj/AnnotationTransactionAspect
java.lang.RuntimeException: key not found in wovenClassFile

Is it possible to fix this issue / can I safely use the old spring-aspects jar in the latest Spring release?

Thanks,

Teun Hoogendoorn