Skip to content

Commit 41e6aa6

Browse files
committed
Restore log level for resolved exceptions
The fix for SPR-17178 switched from debug to warn level warning for all sub-classes of AbstractHandlerExceptionResolver where the request concerned the DefaultHandlerExceptionResolver only. This commit restores the original DEBUG level logging that was in AbstractHandlerExceptionResolver from before SPR-17178. In addition DefaultHandlerExceptionResolver registers a warnLogCategory by default which enables warn logging and hence fulfilling the original goal for SPR-17178. Issue: SPR-17383
1 parent de453ac commit 41e6aa6

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

spring-web/src/main/java/org/springframework/web/server/handler/ResponseStatusExceptionHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ public Mono<Void> handle(ServerWebExchange exchange, Throwable ex) {
7272
if (this.warnLogger != null && this.warnLogger.isWarnEnabled()) {
7373
this.warnLogger.warn(logPrefix + formatError(ex, exchange.getRequest()), ex);
7474
}
75-
else if (logger.isWarnEnabled()) {
76-
logger.warn(logPrefix + formatError(ex, exchange.getRequest()));
75+
else if (logger.isDebugEnabled()) {
76+
logger.debug(logPrefix + formatError(ex, exchange.getRequest()));
7777
}
7878

7979
return exchange.getResponse().setComplete();

spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerExceptionResolver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ public ModelAndView resolveException(
136136
ModelAndView result = doResolveException(request, response, handler, ex);
137137
if (result != null) {
138138
// Print warn message when warn logger is not enabled...
139-
if (logger.isWarnEnabled() && (this.warnLogger == null || !this.warnLogger.isWarnEnabled())) {
140-
logger.warn("Resolved [" + ex + "]" + (result.isEmpty() ? "" : " to " + result));
139+
if (logger.isDebugEnabled() && (this.warnLogger == null || !this.warnLogger.isWarnEnabled())) {
140+
logger.debug("Resolved [" + ex + "]" + (result.isEmpty() ? "" : " to " + result));
141141
}
142142
// warnLogger with full stack trace (requires explicit config)
143143
logException(ex, request);

spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/support/DefaultHandlerExceptionResolver.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ public class DefaultHandlerExceptionResolver extends AbstractHandlerExceptionRes
159159
*/
160160
public DefaultHandlerExceptionResolver() {
161161
setOrder(Ordered.LOWEST_PRECEDENCE);
162+
setWarnLogCategory(getClass().getName());
162163
}
163164

164165

0 commit comments

Comments
 (0)