Issue 2495: Response error codes handling for multi link request #2497

anayonkars · 2025-06-29T17:52:23Z

This PR is to solve issue 2495.

It handles correction of error codes for single association resource. However, it doesn't (yet) handles multiple association resource.

You have read the Spring Data contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

In RepositoryPropertyReferenceController, handled response code for empty links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com>

In RepositoryPropertyReferenceController, handled response code for multiple links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com>

In RepositoryPropertyReferenceController, handled response code where no links are sent (List of Map). Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com>

Fixed test cases Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com>

mp911de

Thanks for submitting a pull request. I added a few comments. Right now, the PR causes more work on our side than it actually helps. Please apply formatting and resolve the commented-out code issues.

Please also squash all commits into one, feel free to force-push.

mp911de · 2025-06-30T13:34:13Z

...rc/main/java/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceController.java


 		Function<ReferencedProperty, RepresentationModel<?>> handler = prop -> {

 			Class<?> propertyType = prop.property.getType();

 			if (prop.property.isCollectionLike()) {
+                /*if(HttpMethod.PATCH.equals(requestMethod)


Why is new code here being commented out?

It's supposed to handle multiple association issue (returning HTTP 204 in case of empty/incorrect header). I've removed the commented code.

mp911de · 2025-06-30T13:34:41Z

...rc/main/java/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceController.java

@@ -237,17 +237,35 @@ public ResponseEntity<RepresentationModel<?>> followPropertyReferenceCompact(Roo
 			consumes = { MediaType.APPLICATION_JSON_VALUE, SPRING_DATA_COMPACT_JSON_VALUE, TEXT_URI_LIST_VALUE })
 	public ResponseEntity<? extends RepresentationModel<?>> createPropertyReference(
 			RootResourceInformation resourceInformation, HttpMethod requestMethod,
-			@RequestBody(required = false) CollectionModel<Object> incoming, @BackendId Serializable id,
+			@RequestBody(required = false) CollectionModel<Object> incoming,
+            @RequestHeader(required = false) HttpHeaders requestHeaders,


Nit: You can find formatting settings at https://github.com/spring-projects/spring-data-build/tree/main/etc/ide

mp911de · 2025-06-30T13:34:54Z

...rc/main/java/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceController.java

@@ -78,6 +77,7 @@ class RepositoryPropertyReferenceController /*extends AbstractRepositoryRestCont

 	private static final String BASE_MAPPING = "/{repository}/{id}/{property}";
 	private static final Collection<HttpMethod> AUGMENTING_METHODS = Arrays.asList(HttpMethod.PATCH, HttpMethod.POST);
+    private static final List<MediaType> SUPPORTED_CONTENT_TYPE = Arrays.asList(MediaType.APPLICATION_JSON, TEXT_URI_LIST);


Nit: We use tab indents, not spaces.

mp911de · 2025-06-30T13:35:20Z

...ava/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceControllerUnitTests.java

+    }
+
+    /*@Test // GH-2495
+    void rejectsInvalidContentTypeForSingleValuedAssociation() throws Exception {


Adding new commented-out code?

It's supposed to handle multiple association issue (returning HTTP 204 in case of empty/incorrect header). I've removed the commented code.

Fixed merge conflicts Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 Cleaned up unnecessary code Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 Fixed test cases Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code where no links are sent (List of Map). Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code for multiple links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code for empty links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> # Conflicts: # spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceController.java # spring-data-rest-webmvc/src/test/java/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceControllerUnitTests.java

Fixed merge conflicts Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 Cleaned up unnecessary code Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 Fixed test cases Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code where no links are sent (List of Map). Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code for multiple links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code for empty links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> # Conflicts: # spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceController.java # spring-data-rest-webmvc/src/test/java/org/springframework/data/rest/webmvc/RepositoryPropertyReferenceControllerUnitTests.java DATAREST-2495 Fixed test cases Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code where no links are sent (List of Map). Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code for multiple links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com> DATAREST-2495 In RepositoryPropertyReferenceController, handled response code for empty links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com>

anayonkars · 2025-06-30T15:24:33Z

Apologies for formatting issues. I was able to configure eclipse formatter in intellij. However, couldn't fix import order. Please review and let me know in case of any issues.

…nse-handling-for-multi-link-request' into bug/spring-projectsGH-2495-Response-handling-for-multi-link-request

anayonkars added 4 commits June 29, 2025 19:24

DATAREST-2495

5ce3d15

In RepositoryPropertyReferenceController, handled response code for empty links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com>

DATAREST-2495

053d07f

In RepositoryPropertyReferenceController, handled response code for multiple links. Instead of IllegalArgumentException and HTTP 500, now it throws HttpMessageNotReadableException and HTTP 400 Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com>

DATAREST-2495

a9d633b

Fixed test cases Signed-off-by: Anayonkar Shivalkar <anayonkar.shivalkar@gmail.com>

anayonkars marked this pull request as ready for review June 29, 2025 17:52

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 29, 2025

anayonkars mentioned this pull request Jun 29, 2025

The response handling when operating on the associated resource relationship seems incorrect? #2495

Open

mp911de assigned odrotbohm Jun 30, 2025

mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 30, 2025

mp911de requested changes Jun 30, 2025

View reviewed changes

anayonkars added 2 commits June 30, 2025 20:44

anayonkars requested a review from mp911de June 30, 2025 15:23

Merge remote-tracking branch 'origin/bug/spring-projectsGH-2495-Respo…

874581b

…nse-handling-for-multi-link-request' into bug/spring-projectsGH-2495-Response-handling-for-multi-link-request

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue 2495: Response error codes handling for multi link request #2497

Issue 2495: Response error codes handling for multi link request #2497

anayonkars commented Jun 29, 2025

Uh oh!

mp911de left a comment

Uh oh!

mp911de Jun 30, 2025

Uh oh!

anayonkars Jun 30, 2025

Uh oh!

mp911de Jun 30, 2025

Uh oh!

anayonkars Jun 30, 2025

Uh oh!

mp911de Jun 30, 2025

Uh oh!

anayonkars Jun 30, 2025

Uh oh!

mp911de Jun 30, 2025

Uh oh!

anayonkars Jun 30, 2025

Uh oh!

anayonkars commented Jun 30, 2025

Uh oh!

Uh oh!

Issue 2495: Response error codes handling for multi link request #2497

Are you sure you want to change the base?

Issue 2495: Response error codes handling for multi link request #2497

Conversation

anayonkars commented Jun 29, 2025

Uh oh!

mp911de left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anayonkars commented Jun 30, 2025

Uh oh!

Uh oh!