Condition.not is broken

[nkey0]

Version 3.2.2.

class NotConditionVisitor extends TypedSubtreeVisitor<NestedCondition> {

should be

class NotConditionVisitor extends TypedSubtreeVisitor<Not> {

https://github.com/spring-projects/spring-data-relational/blob/main/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/NotConditionVisitor.java#L30

Test to reproduce:

    @Test
    public void broken() {
        // when
        Select selectFalse = Select.builder()
                .select(Expressions.just("*"))
                .from("test_table")
                .where(Conditions.just("true").not())
                .build();
        String renderSelectFalse = SqlRenderer.create().render(selectFalse);
        // then - SELECT * FROM test_table
        assertEquals("SELECT * FROM test_table WHERE NOT true", renderSelectFalse)
    }

To be honest, it feels super dangerous.

[schauder]

Thanks for finding and reporting this.

You have a double not in your second test.
Could you confirm that that is a mistake? Otherwise I don't understand the test.

where(Conditions.not(Conditions.nest(Conditions.just("true"))).not())
                 ^                                             ^

[nkey0]

Oh, yes, second part of test is broken. but first one seems to be correct.

(updated issue by removing second test)