Polishing.

Make test methods package private. See #1565
spring-projects · Jul 17, 2024 · a3b8cc5 · a3b8cc5
1 parent 749ce92
commit a3b8cc5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/...ava/org/springframework/data/jdbc/core/convert/SqlIdentifierParameterSourceUnitTests.java b/...ava/org/springframework/data/jdbc/core/convert/SqlIdentifierParameterSourceUnitTests.java
@@ -26,10 +26,10 @@
  * @author Jens Schauder
  * @author Mikhail Polivakha
  */
-public class SqlIdentifierParameterSourceUnitTests {
+class SqlIdentifierParameterSourceUnitTests {
 
 	@Test // DATAJDBC-386
-	public void empty() {
+	void empty() {
 
 		SqlIdentifierParameterSource parameters = new SqlIdentifierParameterSource();
 
@@ -43,7 +43,7 @@ public void empty() {
 	}
 
 	@Test // DATAJDBC-386
-	public void addSingleValue() {
+	void addSingleValue() {
 
 		SqlIdentifierParameterSource parameters = new SqlIdentifierParameterSource();
 
@@ -62,7 +62,7 @@ public void addSingleValue() {
 	}
 
 	@Test // DATAJDBC-386
-	public void addSingleValueWithType() {
+	void addSingleValueWithType() {
 
 		SqlIdentifierParameterSource parameters = new SqlIdentifierParameterSource();
 
@@ -82,7 +82,7 @@ public void addSingleValueWithType() {
 	}
 
 	@Test // DATAJDBC-386
-	public void addOtherDatabaseObjectIdentifierParameterSource() {
+	void addOtherDatabaseObjectIdentifierParameterSource() {
 
 		SqlIdentifierParameterSource parameters = new SqlIdentifierParameterSource();
 		parameters.addValue(SqlIdentifier.unquoted("key1"), 111, 11);

diff --git a/...java/org/springframework/data/jdbc/repository/JdbcRepositoryEmbeddedIntegrationTests.java b/...java/org/springframework/data/jdbc/repository/JdbcRepositoryEmbeddedIntegrationTests.java
@@ -77,7 +77,7 @@ WithDotColumnRepo withDotColumnRepo(JdbcRepositoryFactory factory) {
 	@Autowired WithDotColumnRepo withDotColumnRepo;
 
 	@Test // DATAJDBC-111
-	public void savesAnEntity() {
+	void savesAnEntity() {
 
 		DummyEntity entity = repository.save(createDummyEntity());
 
@@ -86,7 +86,7 @@ public void savesAnEntity() {
 	}
 
 	@Test // DATAJDBC-111
-	public void saveAndLoadAnEntity() {
+	void saveAndLoadAnEntity() {
 
 		DummyEntity entity = repository.save(createDummyEntity());
 
@@ -102,7 +102,7 @@ public void saveAndLoadAnEntity() {
 	}
 
 	@Test // DATAJDBC-111
-	public void findAllFindsAllEntities() {
+	void findAllFindsAllEntities() {
 
 		DummyEntity entity = repository.save(createDummyEntity());
 		DummyEntity other = repository.save(createDummyEntity());
@@ -115,7 +115,7 @@ public void findAllFindsAllEntities() {
 	}
 
 	@Test // GH-1676
-	public void findAllFindsAllEntitiesWithOnlyReferenceNotNull() {
+	void findAllFindsAllEntitiesWithOnlyReferenceNotNull() {
 
 		DummyEntity entity = createDummyEntity();
 		entity.prefixedEmbeddable.test = null;
@@ -130,14 +130,14 @@ public void findAllFindsAllEntitiesWithOnlyReferenceNotNull() {
 	}
 
 	@Test // DATAJDBC-111
-	public void findByIdReturnsEmptyWhenNoneFound() {
+	void findByIdReturnsEmptyWhenNoneFound() {
 
 		// NOT saving anything, so DB is empty
 		assertThat(repository.findById(-1L)).isEmpty();
 	}
 
 	@Test // DATAJDBC-111
-	public void update() {
+	void update() {
 
 		DummyEntity entity = repository.save(createDummyEntity());
 
@@ -153,7 +153,7 @@ public void update() {
 	}
 
 	@Test // DATAJDBC-111
-	public void updateMany() {
+	void updateMany() {
 
 		DummyEntity entity = repository.save(createDummyEntity());
 		DummyEntity other = repository.save(createDummyEntity());
@@ -177,7 +177,7 @@ public void updateMany() {
 	}
 
 	@Test // DATAJDBC-111
-	public void deleteById() {
+	void deleteById() {
 
 		DummyEntity one = repository.save(createDummyEntity());
 		DummyEntity two = repository.save(createDummyEntity());
@@ -191,7 +191,7 @@ public void deleteById() {
 	}
 
 	@Test // DATAJDBC-111
-	public void deleteByEntity() {
+	void deleteByEntity() {
 		DummyEntity one = repository.save(createDummyEntity());
 		DummyEntity two = repository.save(createDummyEntity());
 		DummyEntity three = repository.save(createDummyEntity());
@@ -204,7 +204,7 @@ public void deleteByEntity() {
 	}
 
 	@Test // DATAJDBC-111
-	public void deleteByList() {
+	void deleteByList() {
 
 		DummyEntity one = repository.save(createDummyEntity());
 		DummyEntity two = repository.save(createDummyEntity());
@@ -218,7 +218,7 @@ public void deleteByList() {
 	}
 
 	@Test // DATAJDBC-111
-	public void deleteAll() {
+	void deleteAll() {
 
 		repository.save(createDummyEntity());
 		repository.save(createDummyEntity());
@@ -232,7 +232,7 @@ public void deleteAll() {
 	}
 
 	@Test // DATAJDBC-370
-	public void saveWithNullValueEmbeddable() {
+	void saveWithNullValueEmbeddable() {
 
 		DummyEntity entity = repository.save(new DummyEntity());
 
@@ -241,7 +241,7 @@ public void saveWithNullValueEmbeddable() {
 	}
 
 	@Test // GH-1286
-	public void findOrderedByEmbeddedProperty() {
+	void findOrderedByEmbeddedProperty() {
 
 		Person first = new Person(null, "Bob", "Seattle", new PersonContacts("ddd@example.com", "+1 111 1111 11 11"));
 		Person second = new Person(null, "Alex", "LA", new PersonContacts("aaa@example.com", "+2 222 2222 22 22"));
@@ -256,7 +256,7 @@ public void findOrderedByEmbeddedProperty() {
 	}
 
 	@Test // GH-1286
-	public void sortingWorksCorrectlyIfColumnHasDotInItsName() {
+	void sortingWorksCorrectlyIfColumnHasDotInItsName() {
 
 		WithDotColumn first = new WithDotColumn(null, "Salt Lake City");
 		WithDotColumn second = new WithDotColumn(null, "Istanbul");