Skip to content

DATAJPA-1198 - Consistently avoid toLower(…) translation in Querydsl case-insensitive ORDER BY translation for non-String properties #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

marcusvoltolim
Copy link
Contributor

@marcusvoltolim marcusvoltolim commented Sep 20, 2020

Add condition to add lower in order by only String type

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Add condition to add lower in order by only String type
@marcusvoltolim marcusvoltolim changed the title DATAJPA-1198 DATAJPA-1198;DATAJPA-1779 Sep 20, 2020
@mp911de mp911de changed the title DATAJPA-1198;DATAJPA-1779 DATAJPA-1198 - Consistently avoid toLower(…) translation in Querydsl case-insensitive ORDER BY translation for non-String properties Sep 22, 2020
mp911de pushed a commit that referenced this pull request Sep 23, 2020
…case-insensitive ORDER BY translation for non-String properties.

Original pull request: #428.
mp911de added a commit that referenced this pull request Sep 23, 2020
Compare types using equals(…). Reformat code.

Original pull request: #428.
mp911de pushed a commit that referenced this pull request Sep 23, 2020
…case-insensitive ORDER BY translation for non-String properties.

Original pull request: #428.
mp911de added a commit that referenced this pull request Sep 23, 2020
Compare types using equals(…). Reformat code.

Original pull request: #428.
@mp911de
Copy link
Member

mp911de commented Sep 23, 2020

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants