-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect build to ge.spring.io to benefit from deep build insights and faster builds #3142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change publishes a build scan to ge.spring.io for every local build from an authenticated Spring committer and for CI where appropriate access tokens are available. The build will not fail if publishing fails. This change also allows the build to benefit from local and remote build caching, providing faster builds for all contributors. Additionally, the project will have access to all features of Gradle Enterprise such as: - Dashboards to view all historical build scans, along with performance trends over time - Build failure analytics for enhanced investigation and diagnosis of build failures - Test failure analytics to better understand trends and causes around slow, failing, and flaky tests
Adds builddef.lst to the list of ignored files on the runtime classpath when computing the build cache key. This file contains absolute path references that cause Surefire tests to unnecessarily re-execute.
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Sep 5, 2023
mp911de
added
type: enhancement
A general enhancement
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Sep 5, 2023
gregturn
pushed a commit
that referenced
this pull request
Sep 13, 2023
This change publishes a build scan to ge.spring.io for every local build from an authenticated Spring committer and for CI where appropriate access tokens are available. The build will not fail if publishing fails. This change also allows the build to benefit from local and remote build caching, providing faster builds for all contributors. Additionally, the project will have access to all features of Gradle Enterprise such as: - Dashboards to view all historical build scans, along with performance trends over time - Build failure analytics for enhanced investigation and diagnosis of build failures - Test failure analytics to better understand trends and causes around slow, failing, and flaky tests See #3142
gregturn
pushed a commit
that referenced
this pull request
Sep 13, 2023
This change publishes a build scan to ge.spring.io for every local build from an authenticated Spring committer and for CI where appropriate access tokens are available. The build will not fail if publishing fails. This change also allows the build to benefit from local and remote build caching, providing faster builds for all contributors. Additionally, the project will have access to all features of Gradle Enterprise such as: - Dashboards to view all historical build scans, along with performance trends over time - Build failure analytics for enhanced investigation and diagnosis of build failures - Test failure analytics to better understand trends and causes around slow, failing, and flaky tests See #3142
gregturn
added a commit
that referenced
this pull request
Oct 16, 2023
gregturn
added a commit
that referenced
this pull request
Oct 16, 2023
schauder
added a commit
to spring-projects/spring-data-relational
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request connects the build to the Gradle Enterprise instance at https://ge.spring.io/. This allows the Spring Data JPA project to benefit from deep build insights provided by build scans and faster build speeds for all contributors as a result of local and remote build caching.
This Gradle Enterprise instance has all features and extensions enabled and is freely available for use by Spring Data JPA and all other Spring projects. On this Gradle Enterprise instance, Spring Data JPA will have access not only to all of the published build scans, but other aggregate data features such as:
Spring Boot, Spring Framework, and Spring Security are already connected to https://ge.spring.io/ and are benefiting from these features.
With these changes, in the best case scenario where nothing has changed between two build invocations, I saw local build times go from 2m 47s to 5.7s.
Appropriate access must be configured to publish build scans. To provision a Gradle Enterprise access key for local development, you can invoke the following Maven goal:
For instructions to connect CI to the remote build cache and to publish build scans, please follow the instructions here in Gradle Enterprise Conventions. You can disregard that this is a Gradle plugin, the instructions in the README work the same.
Please let me know if there are any questions about the value of Gradle Enterprise or the changes in this pull request and I’d be happy to address them.