`QueryRewriter` not applied to count queries

[Chandlerigs]

If there are any areas that do not comply with the specifications when submitting an issue for the first time, please help me point them out

I use Spring Data REST and Spring Data JPA to complete my project.

When I use QueryRewrite to complete dynamic queries, there is an error in pagination.

My test demo link is as follows:
github Chandler : data-rest-test

@NoRepositoryBean
public interface BaseRepository<T, ID> extends JpaRepository<T, ID> {
    @Query(value = "select u from #{#entityName} u where 1 = 1", queryRewriter = DynamicQueryRewriter.class)
    Page<T> findByParams(@Nullable @Param("params") String params, @Nullable Pageable pageable);
}

public class DynamicQueryRewriter implements QueryRewriter {
    @Override
    public String rewrite(String query, Sort sort) {
        return query.replaceAll("1 = 1", " u.id >3 ");
    }
}

From the console, it can be seen that, Query SQLis different from countQuery SQL.

The Query SQL calls rewrite and modifies the where condition, while the countQuery SQL does not change, resulting in a total error

There are 5 records in the database, 2 of which comply with the rule (id>3)

When requesting the parameter size=2, the returned totalElements are 5,

When requesting the parameter size!=2 (eg: 4), The returned totalElements are 2,

Thank you for your reading and assistance

[mp911de]

QueryRewriter has been introduced to rewrite entity queries as these are typically the more complex ones. We omitted count query rewriting because that wasn't really in scope. I can see how this is confusing and we should do something about this.

Another aspect to consider is that Hibernate has introduced SelectionQuery.getResultCount() allowing usage of an optimized Hibernate Query without us being required to derive a count query. In such a case, QueryRewriter isn't applied.

[mp911de]

QueryRewriter doesn't say that it is only used for entity queries, however, it makes sense to apply rewriting to both, the entity- and the count query. We need to fix that.

[mp911de]

That's fixed and backported into 3.4.x now.