Skip to content

Commit 1621c93

Browse files
committed
Add unit tests demonstrating issue with query alias discovery in order by clause.
1 parent 98e801c commit 1621c93

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/DefaultQueryUtilsUnitTests.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.junit.jupiter.api.Test;
2626
import org.springframework.dao.InvalidDataAccessApiUsageException;
2727
import org.springframework.data.domain.Sort;
28+
import org.springframework.data.domain.Sort.Direction;
2829
import org.springframework.data.domain.Sort.Order;
2930
import org.springframework.data.jpa.domain.JpaSort;
3031

@@ -438,6 +439,26 @@ void discoversAliasWithComplexFunction() {
438439
.contains("myAlias");
439440
}
440441

442+
@Test
443+
void discoversAliasInQueryWithSpacesAfterComma() {
444+
445+
String query = "select 1 as alias1, 2 as alias2 from MyEntity mnt";
446+
Sort sort = Sort.by(Direction.ASC, "alias2");
447+
System.out.println(applySorting(query, sort));
448+
assertThat(QueryUtils.applySorting(query, sort))
449+
.endsWith("order by alias2 asc");
450+
}
451+
452+
@Test
453+
void discoversAliasInQueryWithoutSpacesAfterComma() {
454+
455+
String query = "select 1 as alias1,2 as alias2 from MyEntity mnt";
456+
Sort sort = Sort.by(Direction.ASC, "alias2");
457+
System.out.println(applySorting(query, sort));
458+
assertThat(QueryUtils.applySorting(query, sort))
459+
.endsWith("order by alias2 asc");
460+
}
461+
441462
@Test // DATAJPA-1506
442463
void detectsAliasWithGroupAndOrderBy() {
443464

0 commit comments

Comments
 (0)