Skip to content

Flyway Ignore Migration Patterns setting can't be set to an empty string #46984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Flyway Ignore Migration Patterns setting can't be set to an empty string #46984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c3849e
Fix: Allow empty string for spring.flyway.ignore-migration-patterns
Chanwon-Seo Aug 28, 2025
6d8b830
Fix Allow ignoreMigrationPatterns to be empty
Chanwon-Seo Aug 29, 2025
ac59c84
Fix Allow ignoreMigrationPatterns to be empty
Chanwon-Seo Aug 29, 2025
cfb097e
Fix Correct assertion order for Flyway ignore migration patterns
Chanwon-Seo Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../src/main/java/org/springframework/boot/flyway/autoconfigure/FlywayAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,6 @@ private void configureProperties(FluentConfiguration configuration, FlywayProper
map.from(properties.getSkipExecutingMigrations())
.to((skipExecutingMigrations) -> configuration.skipExecutingMigrations(skipExecutingMigrations));
map.from(properties.getIgnoreMigrationPatterns())
.whenNot(List::isEmpty)
.to((ignoreMigrationPatterns) -> configuration
.ignoreMigrationPatterns(ignoreMigrationPatterns.toArray(new String[0])));
map.from(properties.getDetectEncoding())
Expand Down
8 changes: 8 additions & 0 deletions ...test/java/org/springframework/boot/flyway/autoconfigure/FlywayAutoConfigurationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,6 +897,14 @@ void ignoreMigrationPatternsCorrectlyMapped() {
.containsExactly(ValidatePattern.fromPattern("*:missing")));
}

@Test
void ignoreMigrationPatternsIsEmpty() {
this.contextRunner.withUserConfiguration(EmbeddedDataSourceConfiguration.class)
.withPropertyValues("spring.flyway.ignore-migration-patterns=")
.run((context) -> assertThat(context.getBean(Flyway.class).getConfiguration().getIgnoreMigrationPatterns())
.isEmpty());
}

private ContextConsumer<AssertableApplicationContext> validateFlywayTeamsPropertyOnly(String propertyName) {
return (context) -> {
assertThat(context).hasFailed();
Expand Down