Remove support for URLConnectionSender in Zipkin autoconfiguration (#43048) #44500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
nosan
reviewed
Mar 2, 2025
There was a problem hiding this comment.
Thank you, @thecooldrop
I've left some comments for your consideration.
| @@ -74,17 +57,6 @@ void shouldBackOffOnCustomBeans() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| void shouldUseCustomHttpEndpointSupplierFactory() { | |||
There was a problem hiding this comment.
Instead of removing this test, I think it should be adjusted. The HttpEndpointSupplier is also used by the ZipkinHttpClientSender. You can remove the FilteredClassLoader(HttpClient.class), retrieve the ZipkinHttpClientSender from the context, and verify that it is configured to use CustomHttpEndpointSupplier.
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldUseUrlConnectionSenderIfHttpClientIsNotAvailable() { |
There was a problem hiding this comment.
Instead of removing this test entirely, you can adjust it to verify:
If HttpClient is not present, then the context should not have ZipkinHttpClientSender.
mhalbritter
requested changes
Mar 5, 2025
| }); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldUseUrlConnectionSenderIfHttpClientIsNotAvailable() { |
| @@ -74,17 +57,6 @@ void shouldBackOffOnCustomBeans() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| void shouldUseCustomHttpEndpointSupplierFactory() { | |||
mhalbritter
added
the
status: waiting-for-feedback
…by removal of URLConnectionSender usages in codebase Signed-off-by: Vanio Begic <vanio.begic123@gmail.com>
|
Hi @mhalbritter thanks for taking a look. I have implemented the requested changes. |
spring-projects-issues
added
status: feedback-provided
… the originally applied to UrlConnectionSender Signed-off-by: Vanio Begic <vanio.begic123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title I have removed and adapted the code which relied on presence of URLConnectionSender from Zipkin. Details in referenced issue #43048