Make ReactiveUserDetailsServiceAutoConfiguration conditional on reactive web app #43350
+50
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
BenchmarkingBuffalo
force-pushed
the
43345-make-ReactiveUserDetailsServiceAutoConfiguration-conditional-on-reactive-web-app
branch
from
fcf5985 to
e7b14f1
Compare
The UserDetailsServiceAutoConfiguration is only to be active in a reactive web application See spring-projectsgh-43345
philwebb
changed the title
philwebb
added
type: enhancement
|
The problem I am facing in this PR is that an RSocket-Application is not automatically recognized as a reactive webapplication. |
|
Hmm yeah, I think we can't do that then. I overlooked the fact that RSocket is also supported by Spring Security. @bclozel WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UserDetailsServiceAutoConfiguration is only to be active in a reactive web application
I tried to align my tests to this commit ff9fde0
But I am not sure, if that is now entirely correct.
If you have remarks, please hit me up :)
See gh-43345