Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service connection from Opentelemetry Collector for Logging #41324

Conversation

eddumelendez
Copy link
Contributor

@eddumelendez eddumelendez commented Jul 5, 2024

Otlp Logging auto-configuration has been added to Spring Boot. This commit adds ConnectionDetails from Docker Compose and Testcontainers.

Should move classes from spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/logging/opentelemetry/otlp/ to spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/logging/otlp/? For consistency with metrics and tracing?

Otlp Logging auto-configuration has been added to Spring Boot. This
commit adds ConnectionDetails from Docker Compose and Testcontainers.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 5, 2024
@wilkinsona wilkinsona added type: enhancement A general enhancement status: on-hold We can't start working on this issue yet and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 11, 2024
@wilkinsona wilkinsona added this to the 3.4.x milestone Jul 11, 2024
@wilkinsona
Copy link
Member

Placing on hold as we'd like to spend a bit of time thinking through our gRPC support across logs, metrics, and tracing.

@wilkinsona wilkinsona removed the status: on-hold We can't start working on this issue yet label Aug 20, 2024
@mhalbritter mhalbritter self-assigned this Sep 6, 2024
mhalbritter pushed a commit that referenced this pull request Sep 6, 2024
Adds ConnectionDetails from Docker Compose and Testcontainers.

See gh-41324
@mhalbritter
Copy link
Contributor

Thanks @eddumelendez !

Are you interested in working on #42163 ?

@mhalbritter mhalbritter modified the milestones: 3.4.x, 3.4.0-M3 Sep 6, 2024
@eddumelendez
Copy link
Contributor Author

Hi @mhalbritter. Yes, I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants