Skip to content

Add ConnectionDetails and ServiceConnection support to Pulsar #37197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add ConnectionDetails and ServiceConnection support to Pulsar #37197

wants to merge 4 commits into from

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Sep 6, 2023 •
edited
Loading

  1. Add connection details to Pulsar auto-configuration.
  2. Add service connection details impl to Pulsar for testcontainers support
  3. Update Pulsar smoke tests to use @ServiceConnection
  4. Add docker compose connection details impl (Docker Compose support)

cc: @eddumelendez @philwebb

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 6, 2023
@mhalbritter
Copy link
Contributor

Hey Chris,

thank you for that PR! Do you know if there's a suitable docker image for Apache Pulsar so that we could add Docker Compose support for Pulsar, too? Ideally we want to have both Testcontainers and Docker Compose support.

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Sep 6, 2023
@onobc
Copy link
Contributor Author

onobc commented Sep 6, 2023

@mhalbritter I already have another commit already queued up to add Docker compose support but wanted to keep this PR smaller. Shall I add the other commit here in this PR? I am ok w/ that and it will take me only a couple mins. Lmk.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 6, 2023
@mhalbritter
Copy link
Contributor

Ah, cool! Yes, please add this commit to this PR too. Then we have the whole ConnectionDetails story for Pulsar in one PR. Thanks!

@philwebb philwebb self-assigned this Sep 6, 2023
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 6, 2023
@philwebb philwebb added this to the 3.2.0-M3 milestone Sep 6, 2023
@philwebb
Copy link
Member

philwebb commented Sep 6, 2023

Thanks @onobc!

philwebb pushed a commit that referenced this pull request Sep 6, 2023
@onobc @philwebb
Add Pulsar ConnectionDetails support
089fef0 
Add `ConnectionDetails` support for Apache Pulsar and provide adapters
for Docker Compose and Testcontainers.

See gh-37197
philwebb added a commit that referenced this pull request Sep 6, 2023
@philwebb
Polish 'Add Pulsar ConnectionDetails support'
750c597 
See gh-37197
@philwebb philwebb closed this in d9af7ce Sep 6, 2023
@onobc onobc deleted the cbono-add-pulsar-connection-details branch May 28, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
status: feedback-provided Feedback has been provided type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.0-M3
Development

Successfully merging this pull request may close these issues.
4 participants
@onobc @mhalbritter @philwebb @spring-projects-issues