Combine Pulsar smoke tests #37196
Closed
Combine Pulsar smoke tests #37196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify produce/consume verify via OutputCapture * Remove spring-boot-smoke-test-pulsar-reactive as no other smoke tests split them out
spring-projects-issues
added
the
status: waiting-for-triage
onobc
commented
Sep 6, 2023
| @@ -32,6 +32,7 @@ | |||
| <suppress files="[\\/]spring-boot-docs[\\/].*MyConfiguration__BeanDefinitions" checks="JavadocMethod|SpringHideUtilityClassConstructor" /> | |||
| <suppress files="[\\/]spring-boot-smoke-tests[\\/]" checks="JavadocPackage|JavadocType" /> | |||
| <suppress files="[\\/]spring-boot-smoke-tests[\\/]" checks="ImportControl" /> | |||
| <suppress files="[\\/]spring-boot-smoke-tests[\\/].*SamplePulsarApplicationTests" checks="SpringHideUtilityClassConstructor" /> | |||
There was a problem hiding this comment.
If there is a better way, please show me.
| expectedOutput.add("++++++PRODUCE IMPERATIVE:(" + i + ")------"); | ||
| expectedOutput.add("++++++CONSUME IMPERATIVE:(" + i + ")------"); | ||
| }); | ||
| Awaitility.waitAtMost(Duration.ofSeconds(30)) |
There was a problem hiding this comment.
Using captured output simplifies by removing the need for the message consumer component and the list of messages etc..
| .pollInterval(Duration.ofMillis(500)) | ||
| .untilAsserted(() -> hasExpectedIds(consumer)); | ||
| @Nested | ||
| @SpringBootTest |
There was a problem hiding this comment.
While these do not use the same spring boot context, they do share the single pulsar container and this makes the test about 2x as fast.
| @SpringBootApplication | ||
| public class SampleReactivePulsarApplication { | ||
| @Configuration(proxyBeanMethods = false) | ||
| @Profile("smoketest.pulsar.reactive") |
There was a problem hiding this comment.
Using the profile approach works well w/ the @ActiveProfiles on the @Nested SBT. I guess the alternative is to use the @SpringBootTest(classes = ... and point directly to a specific app class (imperative or reactive).
philwebb
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Simplify produce/consume verify via OutputCapture * Remove spring-boot-smoke-test-pulsar-reactive as no other smoke tests split them out See gh-37196
philwebb
added a commit
that referenced
this pull request
Sep 6, 2023
wilkinsona
added
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify produce/consume verify via OutputCapture
Remove spring-boot-smoke-test-pulsar-reactive as no other smoke tests split them out