Skip to content

Include junit-platform-launcher in parent POM #17516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dreis2211
Copy link
Contributor

Hi,

after my PR #17491 got merged the full build seems to fail. This PR is an attempt to fix this. I'm very sorry for the inconveniences this causes you and others.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 15, 2019
@wilkinsona
Copy link
Member

Thanks, @dreis2211. No apology is needed. We've tracked the problem down to a bug in Surefire. Your proposal here will, I believe, work around it, but we'd prefer not to have every module depend upon the launcher as they shouldn't need it. @philwebb is working on a solution that uses reflection instead. Please see #17517 for details. If that attempt doesn't work out as we hope it will, we can resurrect this as an alternative.

@wilkinsona wilkinsona closed this Jul 15, 2019
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants