Skip to content

Fix for #16705, chaining closeLater() and adding defered creation of … #16757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix for #16705, chaining closeLater() and adding defered creation of … #16757

wants to merge 1 commit into from

Conversation

AndreasKl
Copy link
Contributor

Fixes #16705 by chaining closeLaster() into the pipeline and obtaining the connection in a non-blocking way.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 8, 2019
@AndreasKl
Copy link
Contributor Author

AndreasKl commented May 9, 2019 •
edited
Loading

Looks like the build failed due to other reasons:

00:39:45 [INFO] Spring Boot Integration Tests 2.2.0.BUILD-SNAPSHOT . SUCCESS [ 12.141 s]
00:39:45 [INFO] Spring Boot Configuration Processor Tests .......... SUCCESS [ 15.076 s]
00:39:45 [INFO] Spring Boot DevTools Tests ......................... SUCCESS [06:34 min]
00:39:45 [INFO] Spring Boot Hibernate 5.2 tests .................... SUCCESS [ 10.531 s]
00:39:45 [INFO] Spring Boot Server Tests ........................... FAILURE [ 46.780 s]
00:39:45 [INFO] Spring Boot Launch Script Integration Tests 2.2.0.BUILD-SNAPSHOT SKIPPED

00:39:44
	
[ERROR] metaInfResourceFromDependencyIsAvailableViaServletContext[Jetty: build system run jar project](org.springframework.boot.context.embedded.EmbeddedServletContainerJarDevelopmentIntegrationTests)  Time elapsed: 15.416 s  <<< ERROR!
00:39:44
	
java.lang.NoClassDefFoundError: org/springframework/util/FileSystemUtils
00:39:44	at org.springframework.boot.context.embedded.BootRunApplicationLauncher.explodeArchive(BootRunApplicationLauncher.java:125)
00:39:44

@wilkinsona
Copy link
Member

Thanks for the PR. @ayudovin has already submitted something for (part of) this and I'd like them to have a chance to finish off that work. I'll place this one on hold for now.

@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label May 9, 2019
@AndreasKl
Copy link
Contributor Author

As the other PR is progressing into a working state closing mine.

@AndreasKl AndreasKl closed this May 9, 2019
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: on-hold We can't start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels May 9, 2019
@wilkinsona
Copy link
Member

Thank you anyway, @AndreasKl, and thanks too for the feedback in #16756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RedisReactiveHealthIndicator blocks on error by calling close, which is not supported in thread reactor-http-epoll
4 participants
@AndreasKl @wilkinsona @philwebb @spring-projects-issues