Skip to content

Enable RestClientAutoConfiguration in reactive web applications when virtual threads are enabled #44912

Closed as not planned
@philwebb

Description

@philwebb

Currently RestClientAutoConfiguration uses NotReactiveWebApplicationCondition so that it is only enabled for non-reactive web applications which helps prevent users from accidentally blocking the event loop thread.

This foot-gun protection is less useful when virtual threads are enabled, as we configure WebFlux with an async task executor which allows blocking calls to be made for any controller method that does not return reactive types. Since RestClientAutoConfiguration provides a lot of helpful functionality, we should relax the condition to a NotReactiveWebApplicationOrVirtualThreadsEnabledCondition

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: supersededAn issue that has been superseded by another

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions