Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move health indicator logging from indicators to a central location #43589

Open
philwebb opened this issue Dec 20, 2024 · 1 comment
Open

Move health indicator logging from indicators to a central location #43589

philwebb opened this issue Dec 20, 2024 · 1 comment
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone
3.x

Comments

@philwebb
Copy link
Member

See #43492 for background.

We'd like to centralize the logging when a health indicator fails so that it can be changed easily. This will involve:

  • Removing the existing logging from AbstractHealthIndicator and AbstractReactiveHealthIndicator (the logExceptionIfPresent method).
  • Updating Health so that the exception can be obtained.
  • Centralizing logging to the code the calls the health indicators.
@philwebb philwebb added the type: enhancement A general enhancement label Dec 20, 2024
@philwebb philwebb added this to the 3.x milestone Dec 20, 2024
@philwebb philwebb mentioned this issue Dec 20, 2024
Closed
@josephabonasara

This comment was marked as outdated.

Sign in to view
@philwebb philwebb added the status: pending-design-work Needs design work before any code can be developed label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
2 participants
@philwebb @josephabonasara