Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-configuration for Observations in Spring-WS #43564

Open
johkin opened this issue Dec 18, 2024 · 1 comment
Open

Add auto-configuration for Observations in Spring-WS #43564

johkin opened this issue Dec 18, 2024 · 1 comment
Labels
status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team type: enhancement A general enhancement
Milestone

Comments

@johkin
Copy link

johkin commented Dec 18, 2024

I have added support for Observations in Spring-WS, and the next step would be to add auto-configuration for the ObservationInterceptors.

As far as I can tell, it could perhaps be implemented in the module spring-boot-actuator-autoconfigure under the package
org.springframework.boot.actuate.autoconfigure.observation.webservice.client or org.springframework.boot.actuate.autoconfigure.observation.webservice.server

For the WebServiceTemplate, the interceptor could probably be added by implementing a WebServiceTemplateCustomizer that is added to the context.
Condition for activating the configuration class could perhaps be @ConditionalOnBean(ObservationRegistry.class)

For the server Endpoints, the interceptor could probably be added in the addInterceptors-callback in the WsConfigurerAdapter.
Condition for activating the configuration class could perhaps be @ConditionalOnBean(ObservationRegistry.class)

The new Observation was merged in spring-projects/spring-ws#1438 for the issue
spring-projects/spring-ws#1094

This is also related to #15390

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 18, 2024
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 19, 2024
@mhalbritter mhalbritter added this to the 3.x milestone Dec 19, 2024
@bclozel
Copy link
Member

bclozel commented Dec 19, 2024

What's the timeline for this feature? I'm not sure how we can properly schedule this on our side.

spring-projects/spring-ws#1438 has been merged but there is no milestone assigned; spring-projects/spring-ws#1094 is not resolved so I guess this means that the observability feature is not complete? It looks like it's merged in the main branch along with 15+ other commits and built as 4.1.0-SNAPSHOT, but the 4.1.0 milestone is in a strange state with a declined issue scheduled in it and zero closed issue (so no way for us to understand what's currently shipped as 4.1.0-SNAPSHOT.

@corneil can you clarify the situation please.

@philwebb philwebb added the status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants