Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow health indicators to run with a specified timeout #43449

Open
philwebb opened this issue Dec 9, 2024 · 3 comments
Open

Allow health indicators to run with a specified timeout #43449

philwebb opened this issue Dec 9, 2024 · 3 comments
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Dec 9, 2024

Originally discussed in #4391 for datasource timeouts, but the problem is more broadly applicable to all health indicators.

@philwebb philwebb added type: enhancement A general enhancement status: pending-design-work Needs design work before any code can be developed labels Dec 9, 2024
@philwebb philwebb added this to the 3.x milestone Dec 9, 2024
@gf-smtzgr
Copy link

This would be neat.
You might also want to separate the status computation from the status retrieval in addition to timeouts. Imho the retrieval of a system status should not be affected by the system status, i.e. if database answers are slow that should not mean the health check should be slow. Thus, ideally a separate thread (pool) regularly updates the health status such that the request handling just needs to readout the current status flags rather than do the status checks to answer the request.

@wilkinsona
Copy link
Member

Thus, ideally a separate thread (pool) regularly updates the health status such that the request handling just needs to readout the current status flags rather than do the status checks to answer the request.

That's #25459.

@gf-smtzgr
Copy link

@wilkinsona thanks! then I can follow that, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants