Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in spring-boot-docker-compose:3.1.0 #35921

Closed
Nick-Wunderdog opened this issue Jun 15, 2023 · 1 comment
Closed

Bugs in spring-boot-docker-compose:3.1.0 #35921

Nick-Wunderdog opened this issue Jun 15, 2023 · 1 comment
Labels
status: invalid An issue that we don't feel is valid

Comments

@Nick-Wunderdog
Copy link

Nick-Wunderdog commented Jun 15, 2023

With Spring Boot 3.1.0 using Maven parent spring-boot-starter-parent:3.1.0 On OpenSuse Linux Leap 15.5. Maven 3.8 with Java JDK Temurin-17.0.7+7. Latest versions of everything at the moment of writing this.

with compose.yaml file at project root (with works ok) runnin
with Docker version

Plugins:
compose: Docker Compose (Docker Inc., v2.0.0-rc.3)

Server:
Server Version: 20.10.23-ce

BUG #1

mvn spring-boot:run

it fails with error :

2023-06-16 00:09:46,326 INFO o.s.b.l.LogLevel [OutputReader-stderr] unknown flag: --wait
2023-06-16 00:09:46,334 ERROR o.s.b.SpringApplication [main] Application run failed
org.springframework.boot.docker.compose.core.ProcessExitException: 'docker compose --file ./compose.yaml --ansi never up --no-color --detach --wait' failed with exit code 16.

docker compose up does not have flag "--wait"

BUG #2

org.springframework.boot.docker.compose.lifecycle.DockerComposeProperties: 283

		/**
		 * Readiness wait strategies.
		 */
		public enum Wait {

			/**
			 * Always perform readiness checks.
			 */
			ALWAYS,

			/**
			 * Always perform readiness checks.
			 */
			NEVER,

ALWAYS and NEVER have same (cut&paste) javadoc

BUG #3

using property : spring.docker.compose.start.command=start
mvn spring-boot:run fails with:

2023-06-16 00:13:06,947 INFO o.s.b.l.LogLevel [OutputReader-stderr] unknown flag: --no-color
2023-06-16 00:13:06,956 ERROR o.s.b.SpringApplication [main] Application run failed
org.springframework.boot.docker.compose.core.ProcessExitException: 'docker compose --file ./compose.yaml --ansi never start --no-color --detach --wait' failed with exit code 16.

docker compose start does not have flag "--no-color"

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 15, 2023
@scottfrederick
Copy link
Contributor

Plugins:
compose: Docker Compose (Docker Inc., v2.0.0-rc.3)

docker compose up does not have flag "--wait"

docker compose start does not have flag "--no-color"

This appears to be a pre-release version of Docker Compose that does not support the command-line flags that Spring Boot requires. The most recent version of the plugin available at the time of this writing is v2.18.1. Please upgrade to a newer version of the Docker Compose plugin.

ALWAYS and NEVER have same (cut&paste) javadoc

This has been fixed in 0ca3ab7.

@scottfrederick scottfrederick added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 15, 2023
@scottfrederick scottfrederick closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

3 participants