Skip to content

Commit fd2b29d

Browse files
committed
Include checking of AutoConfigure….imports in check lifecycle
See gh-47322
1 parent a6a22c1 commit fd2b29d

File tree

3 files changed

+18
-13
lines changed

3 files changed

+18
-13
lines changed

buildSrc/src/main/java/org/springframework/boot/build/test/autoconfigure/TestAutoConfigurationPlugin.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import org.gradle.api.plugins.JavaPlugin;
2323
import org.gradle.api.plugins.JavaPluginExtension;
2424
import org.gradle.api.tasks.SourceSet;
25+
import org.gradle.api.tasks.TaskProvider;
26+
import org.gradle.language.base.plugins.LifecycleBasePlugin;
2527

2628
/**
2729
* {@link Plugin} for projects that define test auto-configuration. When the
@@ -39,16 +41,20 @@ public class TestAutoConfigurationPlugin implements Plugin<Project> {
3941
@Override
4042
public void apply(Project target) {
4143
target.getPlugins().withType(JavaPlugin.class, (plugin) -> {
42-
target.getTasks().register("checkAutoConfigureImports", CheckAutoConfigureImports.class, (task) -> {
43-
SourceSet mainSourceSet = target.getExtensions()
44-
.getByType(JavaPluginExtension.class)
45-
.getSourceSets()
46-
.getByName(SourceSet.MAIN_SOURCE_SET_NAME);
47-
task.setSource(mainSourceSet.getResources());
48-
ConfigurableFileCollection classpath = target.files(mainSourceSet.getRuntimeClasspath(),
49-
target.getConfigurations().getByName(mainSourceSet.getRuntimeClasspathConfigurationName()));
50-
task.setClasspath(classpath);
51-
});
44+
TaskProvider<CheckAutoConfigureImports> checkAutoConfigureImports = target.getTasks()
45+
.register("checkAutoConfigureImports", CheckAutoConfigureImports.class, (task) -> {
46+
SourceSet mainSourceSet = target.getExtensions()
47+
.getByType(JavaPluginExtension.class)
48+
.getSourceSets()
49+
.getByName(SourceSet.MAIN_SOURCE_SET_NAME);
50+
task.setSource(mainSourceSet.getResources());
51+
ConfigurableFileCollection classpath = target.files(mainSourceSet.getRuntimeClasspath(),
52+
target.getConfigurations().getByName(mainSourceSet.getRuntimeClasspathConfigurationName()));
53+
task.setClasspath(classpath);
54+
});
55+
target.getTasks()
56+
.named(LifecycleBasePlugin.CHECK_TASK_NAME)
57+
.configure((check) -> check.dependsOn(checkAutoConfigureImports));
5258
});
5359
}
5460

module/spring-boot-security-test/src/main/java/org/springframework/boot/security/test/autoconfigure/webflux/SecurityWebTestClientAutoConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
package org.springframework.boot.security.test.autoconfigure.webflux;
1818

19+
import org.springframework.boot.autoconfigure.AutoConfiguration;
1920
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2021
import org.springframework.context.annotation.Bean;
21-
import org.springframework.context.annotation.Configuration;
2222
import org.springframework.security.test.web.reactive.server.SecurityMockServerConfigurers;
2323
import org.springframework.test.web.reactive.server.MockServerConfigurer;
2424
import org.springframework.test.web.reactive.server.WebTestClient;
@@ -29,7 +29,7 @@
2929
* @author Madhura Bhave
3030
* @since 4.0.0
3131
*/
32-
@Configuration(proxyBeanMethods = false)
32+
@AutoConfiguration
3333
@ConditionalOnClass(SecurityMockServerConfigurers.class)
3434
public final class SecurityWebTestClientAutoConfiguration {
3535

module/spring-boot-webmvc-test/src/main/resources/META-INF/spring/org.springframework.boot.webmvc.test.autoconfigure.AutoConfigureRestTestClient.imports

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)