Skip to content

Commit aa6e239

Browse files
committed
Merge pull request #33384 from izeye
* 33384: Polish Closes gh-33384
2 parents 39a026e + 90589fd commit aa6e239

File tree

8 files changed

+14
-16
lines changed

8 files changed

+14
-16
lines changed

git/hooks/prepare-forward-merge

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ $log = Logger.new(STDOUT)
1010
$log.level = Logger::WARN
1111

1212
def get_fixed_issues()
13-
$log.debug "Searching for for forward merge"
13+
$log.debug "Searching for forward merge"
1414
rev=`git rev-parse -q --verify MERGE_HEAD`.strip
1515
$log.debug "Found #{rev} from git rev-parse"
1616
return nil unless rev
@@ -65,7 +65,7 @@ if message_type != "merge"
6565
exit 0;
6666
end
6767

68-
$log.debug "Searching for for forward merge"
68+
$log.debug "Searching for forward merge"
6969
fixed = get_fixed_issues()
7070
rewritten_message = rewrite_message(message_file, fixed)
7171
File.write(message_file, rewritten_message)

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/wavefront/WavefrontAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@
3131
import org.springframework.util.StringUtils;
3232

3333
/**
34-
* {@link EnableAutoConfiguration Auto-configuration} for for Wavefront common
35-
* infrastructure.
34+
* {@link EnableAutoConfiguration Auto-configuration} for Wavefront common infrastructure.
3635
*
3736
* @author Moritz Halbritter
3837
* @author Glenn Oppegard

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/prometheus/LazyTracingSpanContextSupplierTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ void whenCurrentSpanHasNoSpanIdThenSpanIdIsNull() {
110110
}
111111

112112
@Test
113-
void whenCurrentSpanHasNoTraceIdThenTraceIdIsFNull() {
113+
void whenCurrentSpanHasNoTraceIdThenTraceIdIsNull() {
114114
Span span = mock(Span.class);
115115
given(this.tracer.currentSpan()).willReturn(span);
116116
TraceContext traceContext = mock(TraceContext.class);

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/BackgroundPreinitializer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ public void run() {
101101
runSafely(new ConversionServiceInitializer());
102102
runSafely(new ValidationInitializer());
103103
if (!runSafely(new MessageConverterInitializer())) {
104-
// If the MessageConverterInitializer we still might be able to
104+
// If the MessageConverterInitializer fails to run, we still might
105+
// be able to
105106
// initialize Jackson
106107
runSafely(new JacksonInitializer());
107108
}

spring-boot-project/spring-boot-docs/src/docs/asciidoc/actuator/metrics.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ By default, Spring MVC related metrics are tagged with the following information
768768
| The request's URI template prior to variable substitution, if possible (for example, `/api/person/\{id}`)
769769
|===
770770

771-
To add to the default tags, provide a `@Bean` that extends `DefaultServerRequestObservationConvention` from the `org.springframework.http.observation` package.
771+
To add to the default tags, provide a `@Bean` that extends `DefaultServerRequestObservationConvention` from the `org.springframework.http.server.observation` package.
772772
To replace the default tags, provide a `@Bean` that implements `ServerRequestObservationConvention`.
773773

774774

@@ -808,7 +808,7 @@ By default, WebFlux related metrics are tagged with the following information:
808808
| The request's URI template prior to variable substitution, if possible (for example, `/api/person/\{id}`)
809809
|===
810810

811-
To add to the default tags, provide a `@Bean` that extends `DefaultServerRequestObservationConvention` from the `org.springframework.http.observation.reactive` package.
811+
To add to the default tags, provide a `@Bean` that extends `DefaultServerRequestObservationConvention` from the `org.springframework.http.server.reactive.observation` package.
812812
To replace the default tags, provide a `@Bean` that implements `ServerRequestObservationConvention`.
813813

814814
TIP: In some cases, exceptions handled in controllers and handler functions are not recorded as request metrics tags.

spring-boot-project/spring-boot-docs/src/docs/asciidoc/actuator/tracing.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Spring Boot ships auto-configuration for the following tracers:
1717

1818
[[actuator.micrometer-tracing.getting-started]]
1919
=== Getting Started
20-
We need an example application that we can use to getting started with tracing.
20+
We need an example application that we can use to get started with tracing.
2121
For our purposes, the simple "`Hello World!`" web application that's covered in the "`<<getting-started#getting-started.first-application>>`" section will suffice.
2222
We're going to use the OpenTelemetry tracer with Zipkin as trace backend.
2323

@@ -77,15 +77,15 @@ All tracer implementations need the `org.springframework.boot:spring-boot-starte
7777
[[actuator.micrometer-tracing.tracer-implementations.otel-zipkin]]
7878
==== OpenTelemetry With Zipkin
7979

80-
* `io.micrometer:micrometer-tracing-bridge-otel` - which is needed to bride the Micrometer Observation API to OpenTelemetry.
80+
* `io.micrometer:micrometer-tracing-bridge-otel` - which is needed to bridge the Micrometer Observation API to OpenTelemetry.
8181
* `io.opentelemetry:opentelemetry-exporter-zipkin` - which is needed to report traces to Zipkin.
8282

8383

8484

8585
[[actuator.micrometer-tracing.tracer-implementations.otel-wavefront]]
8686
==== OpenTelemetry With Wavefront
8787

88-
* `io.micrometer:micrometer-tracing-bridge-otel` - which is needed to bride the Micrometer Observation API to OpenTelemetry.
88+
* `io.micrometer:micrometer-tracing-bridge-otel` - which is needed to bridge the Micrometer Observation API to OpenTelemetry.
8989
* `io.micrometer:micrometer-tracing-reporter-wavefront` - which is needed to report traces to Wavefront.
9090

9191

spring-boot-project/spring-boot-docs/src/docs/asciidoc/native-image/advanced-topics.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,9 @@ include::code:MyRuntimeHints[]
157157

158158
You can then use `@ImportRuntimeHints` on any `@Configuration` class (for example your `@SpringBootApplication` annotated application class) to activate those hints.
159159

160-
If you have classes which needs binding (mostly needed when serializing or deserializing JSON), you can use {spring-framework-docs}/core.html#aot-hints-register-reflection-for-binding[`@RegisterReflectionForBinding`] on any bean.
160+
If you have classes which need binding (mostly needed when serializing or deserializing JSON), you can use {spring-framework-docs}/core.html#aot-hints-register-reflection-for-binding[`@RegisterReflectionForBinding`] on any bean.
161161
Most of the hints are automatically inferred, for example when accepting or returning data from a `@RestController` method.
162-
But when you work with `WebClient` or `RestTemplate` directly, you might need to use `RegisterReflectionForBinding`.
162+
But when you work with `WebClient` or `RestTemplate` directly, you might need to use `@RegisterReflectionForBinding`.
163163

164164
[[native-image.advanced.custom-hints.testing]]
165165
==== Testing custom hints

spring-boot-project/spring-boot-test/src/test/kotlin/org/springframework/boot/test/context/KotlinApplicationWithMainThrowingException.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,8 @@ package org.springframework.boot.test.context
22

33
import org.springframework.boot.SpringBootConfiguration
44
import org.springframework.boot.runApplication
5-
import org.springframework.context.annotation.Configuration
65

7-
@Configuration(proxyBeanMethods = false)
8-
@SpringBootConfiguration
6+
@SpringBootConfiguration(proxyBeanMethods = false)
97
open class KotlinApplicationWithMainThrowingException {
108
}
119

0 commit comments

Comments
 (0)