Skip to content

Commit aa62e3d

Browse files
committed
Fix deprecation issues in WebMvcAutoConfigurationTests
1 parent fc279b7 commit aa62e3d

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@
9696
import org.springframework.web.servlet.FlashMapManager;
9797
import org.springframework.web.servlet.HandlerExceptionResolver;
9898
import org.springframework.web.servlet.LocaleResolver;
99-
import org.springframework.web.servlet.ThemeResolver;
10099
import org.springframework.web.servlet.View;
101100
import org.springframework.web.servlet.ViewResolver;
102101
import org.springframework.web.servlet.config.annotation.AsyncSupportConfigurer;
@@ -458,7 +457,7 @@ public LocaleResolver localeResolver() {
458457
@ConditionalOnMissingBean(name = DispatcherServlet.THEME_RESOLVER_BEAN_NAME)
459458
@Deprecated
460459
@SuppressWarnings("deprecation")
461-
public ThemeResolver themeResolver() {
460+
public org.springframework.web.servlet.ThemeResolver themeResolver() {
462461
return super.themeResolver();
463462
}
464463

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfigurationTests.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@
9494
import org.springframework.web.servlet.HandlerExceptionResolver;
9595
import org.springframework.web.servlet.HandlerMapping;
9696
import org.springframework.web.servlet.LocaleResolver;
97-
import org.springframework.web.servlet.ThemeResolver;
9897
import org.springframework.web.servlet.View;
9998
import org.springframework.web.servlet.ViewResolver;
10099
import org.springframework.web.servlet.config.annotation.AsyncSupportConfigurer;
@@ -126,7 +125,6 @@
126125
import org.springframework.web.servlet.resource.VersionStrategy;
127126
import org.springframework.web.servlet.support.AbstractFlashMapManager;
128127
import org.springframework.web.servlet.support.SessionFlashMapManager;
129-
import org.springframework.web.servlet.theme.FixedThemeResolver;
130128
import org.springframework.web.servlet.view.AbstractView;
131129
import org.springframework.web.servlet.view.ContentNegotiatingViewResolver;
132130
import org.springframework.web.util.UrlPathHelper;
@@ -373,20 +371,25 @@ void customLocaleResolverWithDifferentNameDoesNotReplaceAutoConfiguredLocaleReso
373371
}
374372

375373
@Test
374+
@Deprecated
375+
@SuppressWarnings("deprecation")
376376
void customThemeResolverWithMatchingNameReplacesDefaultThemeResolver() {
377377
this.contextRunner.withBean("themeResolver", CustomThemeResolver.class, CustomThemeResolver::new)
378378
.run((context) -> {
379-
assertThat(context).hasSingleBean(ThemeResolver.class);
379+
assertThat(context).hasSingleBean(org.springframework.web.servlet.ThemeResolver.class);
380380
assertThat(context.getBean("themeResolver")).isInstanceOf(CustomThemeResolver.class);
381381
});
382382
}
383383

384384
@Test
385+
@Deprecated
386+
@SuppressWarnings("deprecation")
385387
void customThemeResolverWithDifferentNameDoesNotReplaceDefaultThemeResolver() {
386388
this.contextRunner.withBean("customThemeResolver", CustomThemeResolver.class, CustomThemeResolver::new)
387389
.run((context) -> {
388390
assertThat(context.getBean("customThemeResolver")).isInstanceOf(CustomThemeResolver.class);
389-
assertThat(context.getBean("themeResolver")).isInstanceOf(FixedThemeResolver.class);
391+
assertThat(context.getBean("themeResolver"))
392+
.isInstanceOf(org.springframework.web.servlet.theme.FixedThemeResolver.class);
390393
});
391394
}
392395

@@ -1482,7 +1485,8 @@ public void setLocale(HttpServletRequest request, HttpServletResponse response,
14821485

14831486
}
14841487

1485-
static class CustomThemeResolver implements ThemeResolver {
1488+
@Deprecated
1489+
static class CustomThemeResolver implements org.springframework.web.servlet.ThemeResolver {
14861490

14871491
@Override
14881492
public String resolveThemeName(HttpServletRequest request) {

0 commit comments

Comments
 (0)