Skip to content

Commit 4b5cc0b

Browse files
committed
Disable flush mode property mapping for reactive Redis session
1 parent ac6d7c4 commit 4b5cc0b

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/session/RedisReactiveSessionConfiguration.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ public void customize(SessionProperties sessionProperties, RedisSessionPropertie
5353
setMaxInactiveIntervalInSeconds((int) timeout.getSeconds());
5454
}
5555
setRedisNamespace(redisSessionProperties.getNamespace());
56-
setRedisFlushMode(redisSessionProperties.getFlushMode());
5756
}
5857

5958
}

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/session/ReactiveSessionAutoConfigurationRedisTests.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.springframework.boot.test.context.runner.ReactiveWebApplicationContextRunner;
2828
import org.springframework.session.data.mongo.ReactiveMongoOperationsSessionRepository;
2929
import org.springframework.session.data.redis.ReactiveRedisOperationsSessionRepository;
30-
import org.springframework.session.data.redis.RedisFlushMode;
3130

3231
import static org.assertj.core.api.Assertions.assertThat;
3332

@@ -48,34 +47,31 @@ void defaultConfig() {
4847
this.contextRunner.withPropertyValues("spring.session.store-type=redis")
4948
.withConfiguration(
5049
AutoConfigurations.of(RedisAutoConfiguration.class, RedisReactiveAutoConfiguration.class))
51-
.run(validateSpringSessionUsesRedis("spring:session:", RedisFlushMode.ON_SAVE));
50+
.run(validateSpringSessionUsesRedis("spring:session:"));
5251
}
5352

5453
@Test
5554
void defaultConfigWithUniqueStoreImplementation() {
5655
this.contextRunner.withClassLoader(new FilteredClassLoader(ReactiveMongoOperationsSessionRepository.class))
5756
.withConfiguration(
5857
AutoConfigurations.of(RedisAutoConfiguration.class, RedisReactiveAutoConfiguration.class))
59-
.run(validateSpringSessionUsesRedis("spring:session:", RedisFlushMode.ON_SAVE));
58+
.run(validateSpringSessionUsesRedis("spring:session:"));
6059
}
6160

6261
@Test
6362
void redisSessionStoreWithCustomizations() {
6463
this.contextRunner
6564
.withConfiguration(
6665
AutoConfigurations.of(RedisAutoConfiguration.class, RedisReactiveAutoConfiguration.class))
67-
.withPropertyValues("spring.session.store-type=redis", "spring.session.redis.namespace=foo",
68-
"spring.session.redis.flush-mode=immediate")
69-
.run(validateSpringSessionUsesRedis("foo:", RedisFlushMode.IMMEDIATE));
66+
.withPropertyValues("spring.session.store-type=redis", "spring.session.redis.namespace=foo")
67+
.run(validateSpringSessionUsesRedis("foo:"));
7068
}
7169

72-
private ContextConsumer<AssertableReactiveWebApplicationContext> validateSpringSessionUsesRedis(String namespace,
73-
RedisFlushMode flushMode) {
70+
private ContextConsumer<AssertableReactiveWebApplicationContext> validateSpringSessionUsesRedis(String namespace) {
7471
return (context) -> {
7572
ReactiveRedisOperationsSessionRepository repository = validateSessionRepository(context,
7673
ReactiveRedisOperationsSessionRepository.class);
7774
assertThat(repository).hasFieldOrPropertyWithValue("namespace", namespace);
78-
assertThat(repository).hasFieldOrPropertyWithValue("redisFlushMode", flushMode);
7975
};
8076
}
8177

0 commit comments

Comments
 (0)