Merge pull request #36062 from quaff

* pr/36062: Polish "Replace @CsvSource with @valuesource where feasible" Replace @CsvSource with @valuesource where feasible Closes gh-36062
spring-projects · Jul 17, 2023 · 08054cf · 08054cf
2 parents beb4010 + 09e5d38
commit 08054cf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...ramework/boot/testsupport/classpath/ModifiedClassPathExtensionForkParameterizedTests.java b/...ramework/boot/testsupport/classpath/ModifiedClassPathExtensionForkParameterizedTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2022 the original author or authors.
+ * Copyright 2012-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,7 +20,7 @@
 import java.util.List;
 
 import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.ValueSource;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
@@ -35,7 +35,7 @@ class ModifiedClassPathExtensionForkParameterizedTests {
 	private static final List<String> arguments = new ArrayList<>();
 
 	@ParameterizedTest
-	@CsvSource({ "one", "two", "three" })
+	@ValueSource(strings = { "one", "two", "three" })
 	void testIsInvokedOnceForEachArgument(String argument) {
 		if (argument.equals("one")) {
 			assertThat(arguments).isEmpty();

diff --git a/...oot/src/test/java/org/springframework/boot/context/config/ConfigDataEnvironmentTests.java b/...oot/src/test/java/org/springframework/boot/context/config/ConfigDataEnvironmentTests.java
@@ -28,7 +28,7 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInfo;
 import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.ValueSource;
 
 import org.springframework.boot.ConfigurableBootstrapContext;
 import org.springframework.boot.DefaultBootstrapContext;
@@ -229,7 +229,7 @@ protected ConfigDataEnvironmentContributors createContributors(
 	}
 
 	@ParameterizedTest
-	@CsvSource({ "include", "include[0]" })
+	@ValueSource(strings = { "include", "include[0]" })
 	void processAndApplyWhenHasProfileIncludeInProfileSpecificDocumentThrowsException(String property, TestInfo info) {
 		this.environment.setProperty("spring.config.location", getConfigLocation(info));
 		ConfigDataEnvironment configDataEnvironment = new ConfigDataEnvironment(this.logFactory, this.bootstrapContext,
@@ -253,7 +253,7 @@ protected ConfigDataEnvironmentContributors createContributors(
 	}
 
 	@ParameterizedTest
-	@CsvSource({ "spring.profiles.include", "spring.profiles.include[0]" })
+	@ValueSource(strings = { "spring.profiles.include", "spring.profiles.include[0]" })
 	void processAndApplyIncludesProfilesFromSpringProfilesInclude(String property, TestInfo info) {
 		this.environment.setProperty("spring.config.location", getConfigLocation(info));
 		ConfigDataEnvironment configDataEnvironment = new ConfigDataEnvironment(this.logFactory, this.bootstrapContext,