-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Migrate spring-batch-infrastructure
to JSpecify annotations
#4864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
35c9da1
to
c737967
Compare
38292b1
to
fee88d7
Compare
8e2edf2
to
abeb820
Compare
...re/src/main/java/org/springframework/batch/item/adapter/AbstractMethodInvokingDelegator.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/springframework/batch/item/adapter/AbstractMethodInvokingDelegator.java
Outdated
Show resolved
Hide resolved
f7c8989
to
3be2fa5
Compare
...ng-batch-infrastructure/src/main/java/org/springframework/batch/item/KeyValueItemWriter.java
Outdated
Show resolved
Hide resolved
This is a huge amount of work.. thank you very much for contributing this PR! I REALLY appreciate your time and effort on this 🙏 I am targeting the migration to jSpecify for v6.0.0-M3 (planned for Sep 17th), so I will start working on this right after releasing 6.0.0-M2. I see that the PR is still in draft status, which is ok, but is there a module I can I start reviewing? Just as a (self) reminder, we need to get rid of the |
Hi @fmbenhassine, I couldn't spend time on it in the last weeks, but I'll be able to get back to it this week and make sure it'll be in the right shape in time for M3 (including giving you time for review, of course 🙂) So far, I approached it by executing the full build and addressing the problems in a mostly sequential order. I'll rebase my branch and see if I can split the changes into smaller PRs so that the review becomes easier. |
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
spring-batch-infrastructure
to JSpecify annotations
@fmbenhassine I'm reducing the scope of this PR to (as you wisely proposed in the past 🙃) |
39ac0a3
to
dfd06e7
Compare
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
This change also introduces NullAway to verify
@NullMarked
annotated packages.This also includes the changes from #4959, but I'll rebase this PR once that one is merged.