Skip to content

Conversation

scordio
Copy link
Contributor

@scordio scordio commented Jun 8, 2025

This change also introduces NullAway to verify @NullMarked annotated packages.

This also includes the changes from #4959, but I'll rebase this PR once that one is merged.

@fmbenhassine
Copy link
Contributor

This is a huge amount of work.. thank you very much for contributing this PR! I REALLY appreciate your time and effort on this 🙏

I am targeting the migration to jSpecify for v6.0.0-M3 (planned for Sep 17th), so I will start working on this right after releasing 6.0.0-M2. I see that the PR is still in draft status, which is ok, but is there a module I can I start reviewing?

Just as a (self) reminder, we need to get rid of the com.google.code.findbugs:jsr305 dependency as part of this.

@scordio
Copy link
Contributor Author

scordio commented Aug 20, 2025

Hi @fmbenhassine, I couldn't spend time on it in the last weeks, but I'll be able to get back to it this week and make sure it'll be in the right shape in time for M3 (including giving you time for review, of course 🙂)

So far, I approached it by executing the full build and addressing the problems in a mostly sequential order. I'll rebase my branch and see if I can split the changes into smaller PRs so that the review becomes easier.

Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
@scordio scordio changed the title Migrate to JSpecify annotations for nullability constraints Migrate spring-batch-infrastructure to JSpecify annotations Aug 21, 2025
@scordio
Copy link
Contributor Author

scordio commented Aug 21, 2025

@fmbenhassine I'm reducing the scope of this PR to spring-batch-infrastructure for a simpler review (I guess you could remove some labels), and I'll raise separate PRs for the other modules.

(as you wisely proposed in the past 🙃)

@scordio scordio force-pushed the jspecify branch 5 times, most recently from 39ac0a3 to dfd06e7 Compare August 24, 2025 11:41
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants