Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MongoItemReader to MongoPagingItemReader #4341

Closed
fmbenhassine opened this issue Mar 29, 2023 · 3 comments
Closed

Rename MongoItemReader to MongoPagingItemReader #4341

fmbenhassine opened this issue Mar 29, 2023 · 3 comments
Assignees
@fmbenhassine
Labels
in: infrastructure status: for-internal-team Issues that are planned to be resolved by the Spring Batch team, and not open for contributions. type: enhancement
Milestone
5.1.0-M2

Comments

@fmbenhassine
Copy link
Contributor

With #4323 planned for 5.1, the MongoItemReader should be renamed to MongoPagingItemReader as it uses paging to read data from MongoDB. This naming change is for consistency with other reader implementations like JDBC (JdbcCursorItemReader / JdbcPagingItemReader), JPA (JpaCursorItemReader, JpaPagingItemReader), etc.
@fmbenhassine fmbenhassine added in: infrastructure type: enhancement status: for-internal-team Issues that are planned to be resolved by the Spring Batch team, and not open for contributions. labels Mar 29, 2023
@fmbenhassine fmbenhassine added this to the 5.1.0 milestone Mar 29, 2023
@fmbenhassine fmbenhassine self-assigned this Mar 29, 2023
@fmbenhassine fmbenhassine mentioned this issue Mar 29, 2023
Closed
@sukanth
Copy link
Contributor

sukanth commented May 12, 2023

@fmbenhassine i can do this too :-)

@fmbenhassine
Copy link
Contributor Author

@sukanth Thank you for all your effort and PRs! I like the momentum you got on the project 👍

However, this one is tagged with status: for-internal-team, which means we prefer keeping it for the internal team to work on.

Thank you for your offer to help anyway.

@sukanth
Copy link
Contributor

sukanth commented May 12, 2023

@sukanth Thank you for all your effort and PRs! I like the momentum you got on the project 👍

However, this one is tagged with status: for-internal-team, which means we prefer keeping it for the internal team to work on.

Thank you for your offer to help anyway.

No Problem Thank you :-)

@fmbenhassine fmbenhassine modified the milestones: 5.1.0, 5.1.0-M2 Aug 22, 2023
@fmbenhassine fmbenhassine mentioned this issue Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmbenhassine fmbenhassine

Labels
in: infrastructure status: for-internal-team Issues that are planned to be resolved by the Spring Batch team, and not open for contributions. type: enhancement
Projects
None yet
Milestone
5.1.0-M2
Development

No branches or pull requests
2 participants
@fmbenhassine @sukanth