Skip to content

Commit 5bf8a61

Browse files
committed
Add AbstractTaskletStepBuilder copy constructor and testcode
This commit includes tests for the copy constructor of AbstractTaskletStepBuilder and for the faultTolerant method, specifically after taskExecutor has been set.
1 parent 2eeb101 commit 5bf8a61

File tree

2 files changed

+132
-0
lines changed

2 files changed

+132
-0
lines changed

spring-batch-core/src/main/java/org/springframework/batch/core/step/builder/AbstractTaskletStepBuilder.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
* @author Dave Syer
5050
* @author Michael Minella
5151
* @author Mahmoud Ben Hassine
52+
* @author Ilpyo Yang
5253
* @since 2.2
5354
* @param <B> the type of builder represented
5455
*/
@@ -74,6 +75,23 @@ public AbstractTaskletStepBuilder(StepBuilderHelper<?> parent) {
7475
super(parent);
7576
}
7677

78+
/**
79+
* Create a new builder initialized with any properties in the parent. The parent is
80+
* copied, so it can be re-used.
81+
* @param parent a parent helper containing common step properties
82+
*/
83+
public AbstractTaskletStepBuilder(AbstractTaskletStepBuilder<?> parent) {
84+
super(parent);
85+
this.chunkListeners = parent.chunkListeners;
86+
this.stepOperations = parent.stepOperations;
87+
this.transactionManager = parent.transactionManager;
88+
this.transactionAttribute = parent.transactionAttribute;
89+
this.streams.addAll(parent.streams);
90+
this.exceptionHandler = parent.exceptionHandler;
91+
this.throttleLimit = parent.throttleLimit;
92+
this.taskExecutor = parent.taskExecutor;
93+
}
94+
7795
protected abstract Tasklet createTasklet();
7896

7997
/**
Lines changed: 114 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
1+
package org.springframework.batch.test;
2+
/*
3+
* Copyright 2020-2022 the original author or authors.
4+
*
5+
* Licensed under the Apache License, Version 2.0 (the "License");
6+
* you may not use this file except in compliance with the License.
7+
* You may obtain a copy of the License at
8+
*
9+
* https://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
18+
import static org.junit.Assert.assertEquals;
19+
import static org.mockito.Mockito.mock;
20+
21+
import java.lang.reflect.Constructor;
22+
import java.lang.reflect.Field;
23+
import org.junit.jupiter.api.BeforeEach;
24+
import org.junit.jupiter.api.Test;
25+
import org.springframework.batch.core.repository.JobRepository;
26+
import org.springframework.batch.core.step.builder.AbstractTaskletStepBuilder;
27+
import org.springframework.batch.core.step.builder.SimpleStepBuilder;
28+
import org.springframework.batch.core.step.builder.StepBuilderHelper;
29+
import org.springframework.batch.item.ItemProcessor;
30+
import org.springframework.batch.item.ItemReader;
31+
import org.springframework.batch.item.ItemWriter;
32+
import org.springframework.batch.test.context.SpringBatchTest;
33+
import org.springframework.core.task.SimpleAsyncTaskExecutor;
34+
import org.springframework.core.task.TaskExecutor;
35+
import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
36+
37+
/**
38+
* Test cases for verifying the {@link AbstractTaskletStepBuilder} and faultTolerant() functionality.
39+
*
40+
* @author Ilpyo Yang
41+
*/
42+
@SpringBatchTest
43+
@SpringJUnitConfig
44+
public class AbstractTaskletStepBuilderTests {
45+
private final JobRepository jobRepository = mock(JobRepository.class);
46+
private final int chunkSize = 10;
47+
private final ItemReader itemReader = mock(ItemReader.class);
48+
private final ItemProcessor itemProcessor = mock(ItemProcessor.class);
49+
private final ItemWriter itemWriter = mock(ItemWriter.class);
50+
private final SimpleAsyncTaskExecutor taskExecutor = new SimpleAsyncTaskExecutor();
51+
SimpleStepBuilder simpleStepBuilder;
52+
53+
private <T> T accessPrivateField(Object o, String fieldName) throws ReflectiveOperationException {
54+
Field field = o.getClass().getDeclaredField(fieldName);
55+
field.setAccessible(true);
56+
return (T) field.get(o);
57+
}
58+
59+
private <T> T accessSuperClassPrivateField(Object o, String fieldName) throws ReflectiveOperationException {
60+
Field field = o.getClass().getSuperclass().getDeclaredField(fieldName);
61+
field.setAccessible(true);
62+
return (T) field.get(o);
63+
}
64+
65+
@BeforeEach
66+
void set(){
67+
StepBuilderHelper stepBuilderHelper = new StepBuilderHelper("test", jobRepository) {
68+
@Override
69+
protected StepBuilderHelper self() {
70+
return null;
71+
}
72+
};
73+
simpleStepBuilder = new SimpleStepBuilder(stepBuilderHelper);
74+
simpleStepBuilder.chunk(chunkSize);
75+
simpleStepBuilder.reader(itemReader);
76+
simpleStepBuilder.processor(itemProcessor);
77+
simpleStepBuilder.writer(itemWriter);
78+
}
79+
80+
@Test
81+
void copyConstractorTest() throws ReflectiveOperationException {
82+
Constructor<SimpleStepBuilder> constructor = SimpleStepBuilder.class.getDeclaredConstructor(SimpleStepBuilder.class);
83+
constructor.setAccessible(true);
84+
SimpleStepBuilder copySimpleStepBuilder = constructor.newInstance(simpleStepBuilder);
85+
86+
int copyChunkSize = accessPrivateField(copySimpleStepBuilder, "chunkSize");
87+
ItemReader copyItemReader = accessPrivateField(copySimpleStepBuilder, "reader");
88+
ItemProcessor copyItemProcessor = accessPrivateField(copySimpleStepBuilder, "processor");
89+
ItemWriter copyItemWriter = accessPrivateField(copySimpleStepBuilder, "writer");
90+
91+
assertEquals(chunkSize, copyChunkSize);
92+
assertEquals(itemReader, copyItemReader);
93+
assertEquals(itemProcessor, copyItemProcessor);
94+
assertEquals(itemWriter, copyItemWriter);
95+
}
96+
97+
@Test
98+
void faultTolerantMethodTest() throws ReflectiveOperationException {
99+
simpleStepBuilder.taskExecutor(taskExecutor); // The task executor is set before faultTolerant()
100+
simpleStepBuilder.faultTolerant();
101+
102+
int afterChunkSize = accessPrivateField(simpleStepBuilder, "chunkSize");
103+
ItemReader afterItemReader = accessPrivateField(simpleStepBuilder, "reader");
104+
ItemProcessor afterItemProcessor = accessPrivateField(simpleStepBuilder, "processor");
105+
ItemWriter afterItemWriter = accessPrivateField(simpleStepBuilder, "writer");
106+
TaskExecutor afterTaskExecutor = accessSuperClassPrivateField(simpleStepBuilder, "taskExecutor");
107+
108+
assertEquals(chunkSize, afterChunkSize);
109+
assertEquals(itemReader, afterItemReader);
110+
assertEquals(itemProcessor, afterItemProcessor);
111+
assertEquals(itemWriter, afterItemWriter);
112+
assertEquals(taskExecutor, afterTaskExecutor);
113+
}
114+
}

0 commit comments

Comments
 (0)