Skip to content

Recipe AddRepositoryAction doesn't check condition NoRepositoryExistsCondition #241

@ashakirin

Description

@ashakirin

The Recipe AddRepositoryAction has the following condition configuration:

      description: Add Spring Boot milestone repository.
      id: "spring-milestone"
      url: "https://repo.spring.io/milestone"
      snapshotsEnabled: false
      condition:
        type: org.springframework.sbm.build.migration.conditions.NoRepositoryExistsCondition
        id: "spring-milestone"
        url: "https://repo.spring.io/milestone"

However recipe generates doubled spring-milestone repository entry, if it already exists in pom before:

		<repository>
			<id>spring-milestone</id>
			<url>https://repo.spring.io/milestone</url>
			<snapshots>
				<enabled>false</enabled>
			</snapshots>
		</repository>
		<repository>
			<id>spring-release</id>
			<url>https://repo.spring.io/release</url>
			<snapshots>
				<enabled>false</enabled>
			</snapshots>
		</repository>
		<repository>
			<id>spring-milestone</id>
			<url>https://repo.spring.io/milestone</url>
		</repository>

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions