Support GitHub Auth method #751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Jun 4, 2025
|
|
||
| @Nested | ||
| @TestPropertySource(properties = { "spring.cloud.vault.github.token=gho_00000000-0000-0000-0000-000000000000" }) | ||
| class GitHubTokenSuppliedByPropertyTest { |
There was a problem hiding this comment.
For the time being, please avoid using @Nested test classes. Instead, rewrite these to config classes and test these via methods in the main test class.
There was a problem hiding this comment.
Done.
I rewrote unit tests with JUnit 4 inspired by VaultBootstrapperIntegrationTests
There was a problem hiding this comment.
This unit test is now migrated to JUnit5 as it is supported now in spring-cloud-vault
Fixes spring-cloudgh-727 Signed-off-by: Issam El-atif <issam.elatif@gmail.com>
Signed-off-by: Issam El-atif <issam.elatif@gmail.com>
Signed-off-by: Issam El-atif <issam.elatif@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-727