Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Open Feign must support multiple interface inheritance #413

Open
silkentrance opened this issue Oct 7, 2020 · 3 comments
Open

WIP: Open Feign must support multiple interface inheritance #413

silkentrance opened this issue Oct 7, 2020 · 3 comments
Labels
enhancement New feature or request icebox

Comments

@silkentrance
Copy link

silkentrance commented Oct 7, 2020

WIP Notice

I am currently working on this feature request across multiple repositories, so this this will be updated multiple times. Once finished, this notice will be removed. As soon as this notice gets removed, there will be a PR for spring-cloud-openfeign.

Problem

The current problem with OpenFeign is that one cannot inherit from multiple interfaces. And while the current contract,, i.e. single inheritance of annotated interfaces, should be supported in a backward compatitble way, I see no reason why one should prevent the user to inherit from multiple interfaces or marker interfaces even, and recursively so.

Describe the solution you'd like

Feign client interfaces should support multi-level, multiple inheritance.

Describe alternatives you've considered

There are no alternatives unless you come up with a better solution to the problem.

Additional context

I am currently working on a PR for the open feign project to incorporate such measures, meaning that the Contract.BaseContract functionality will be extended so that the IMO artificial restriction on inheritance will be removed altogether.

This will require no changes to spring-cloud except for updating the openfeign dependency.

@OlgaMaciaszek
Copy link
Collaborator

Thanks, @silkentrance. We will need to see what happens with the issue and PR in Feign core first. Please comment here once the PR has been merged there.

@OlgaMaciaszek OlgaMaciaszek added enhancement New feature or request icebox and removed waiting-for-triage labels Oct 28, 2020
@silkentrance
Copy link
Author

@OlgaMaciaszek Thank you for the reply. I was already convinced that due to the ongoing pandemic, all work had been cancelled.

@OlgaMaciaszek
Copy link
Collaborator

No, @silkentrance we just have a small team maintaining a big number of projects. The OpenFeign team is independent from us, though, so first let's see what happens with the changes you've submitted in that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request icebox
Projects
None yet
Development

No branches or pull requests

3 participants