Skip to content

Commit 428ebab

Browse files
authored
first test (#1853)
Signed-off-by: wind57 <eugen.rabii@gmail.com>
1 parent b6bedd1 commit 428ebab

File tree

7 files changed

+4
-17
lines changed

7 files changed

+4
-17
lines changed

.github/workflows/composites/maven-build-with-dry-run-for-tests/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
shell: bash
99
run: |
1010
./mvnw install -B \
11-
-Dskip.build.image=true \
11+
-Dspring-boot.build-image.skip=true \
1212
-DskipTests -DskipITs \
1313
-T 1C -U -q
1414

.github/workflows/composites/pre-test-actions/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ runs:
2424
- name: build project
2525
shell: bash
2626
run: |
27-
./mvnw clean install -Dskip.build.image=true -DskipITs -DskipTests -T1C -U -B -q
27+
./mvnw clean install -Dspring-boot.build-image.skip=true -DskipITs -DskipTests -T1C -U -B -q
2828
2929
- name: build controllers project
3030
uses: ./.github/workflows/composites/build-controllers-project

.github/workflows/composites/run-and-save-test-times-when-cache-missing/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ runs:
4747
-Dmaven.wagon.http.pool=false \
4848
-Dmaven.wagon.http.retryHandler.class=standard \
4949
-Dmaven.wagon.http.retryHandler.count=3 \
50-
-Dskip.build.image=true
50+
-Dspring-boot.build-image.skip=true
5151
5252
touch /tmp/test_times_${{ env.CURRENT_INDEX }}.txt
5353

.github/workflows/composites/run-and-save-test-times-when-cache-present/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ runs:
156156
-Dmaven.wagon.http.pool=false \
157157
-Dmaven.wagon.http.retryHandler.class=standard \
158158
-Dmaven.wagon.http.retryHandler.count=3 \
159-
-Dskip.build.image=true
159+
-Dspring-boot.build-image.skip=true
160160

161161
touch /tmp/test_times_${{ env.CURRENT_INDEX }}.txt
162162

spring-cloud-kubernetes-controllers/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@
3333
<executions>
3434
<execution>
3535
<id>build-image</id>
36-
<configuration>
37-
<skip>${skip.build.image}</skip>
38-
</configuration>
3936
<phase>package</phase>
4037
<goals>
4138
<goal>build-image-no-fork</goal>

spring-cloud-kubernetes-integration-tests/README

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ you must name the image with the same name as the module. For example:
1313
<executions>
1414
<execution>
1515
<id>build-image</id>
16-
<configuration>
17-
<skip>${skip.build.image}</skip>
18-
</configuration>
1916
<phase>package</phase>
2017
<goals>
2118
<goal>build-image-no-fork</goal>
@@ -36,7 +33,3 @@ Notice this line:
3633
<imageName>docker.io/springcloud/${project.artifactId}:${project.version}</imageName>
3734

3835
You must follow the same convention.
39-
40-
One more important part in this configuration is : "<skip>${skip.build.image}</skip>".
41-
We use this setting in the build pipeline where in some stages we skip the image build,
42-
only to have it build in some latter ones.

spring-cloud-kubernetes-integration-tests/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@
3838
<executions>
3939
<execution>
4040
<id>build-image</id>
41-
<configuration>
42-
<skip>${skip.build.image}</skip>
43-
</configuration>
4441
<phase>package</phase>
4542
<goals>
4643
<goal>build-image-no-fork</goal>

0 commit comments

Comments
 (0)