Skip to content

Commit 1eec4a0

Browse files
authored
fix (#1847)
Signed-off-by: wind57 <eugen.rabii@gmail.com>
1 parent c44fbeb commit 1eec4a0

File tree

5 files changed

+25
-141
lines changed

5 files changed

+25
-141
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
/**
4545
* @author wind57
4646
*/
47-
class BootstrapEnabledPollingReloadConfigMapMountIT {
47+
class Fabric8ConfigMapMountMountPollingBootstrapIT {
4848

4949
private static final String IMAGE_NAME = "spring-cloud-kubernetes-fabric8-client-reload";
5050

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
/**
4545
* @author wind57
4646
*/
47-
class ConfigMapMountPollingReloadDelegateIT {
47+
class Fabric8ConfigMapMountPollingReloadIT {
4848

4949
private static final String IMAGE_NAME = "spring-cloud-kubernetes-fabric8-client-reload";
5050

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"logging.level.org.springframework.cloud.kubernetes.fabric8.config.reload=debug",
4949
"spring.cloud.bootstrap.enabled=true" })
5050
@ActiveProfiles("two")
51-
class Fabric8EventReloadInformIT extends Fabric8EventReloadBase {
51+
class Fabric8EventReloadConfigMapBootstrapIT extends Fabric8EventReloadBase {
5252

5353
private static final String LEFT_NAMESPACE = "left";
5454

@@ -109,7 +109,27 @@ void test(CapturedOutput output) {
109109
assertThat(leftProperties.getValue()).isEqualTo("left-initial");
110110
assertThat(rightProperties.getValue()).isEqualTo("right-initial");
111111

112-
// then deploy a new version of right-configmap
112+
// then deploy a new version of right-configmap, but without changing its data,
113+
// only add a label, thus no refresh happens
114+
ConfigMap configMap = new ConfigMapBuilder()
115+
.withMetadata(new ObjectMetaBuilder().withLabels(Map.of("new-label", "abc"))
116+
.withNamespace(RIGHT_NAMESPACE)
117+
.withName("right-configmap")
118+
.build())
119+
.withData(Map.of("right.value", "right-initial"))
120+
.build();
121+
122+
replaceConfigMap(kubernetesClient, configMap, RIGHT_NAMESPACE);
123+
124+
await().atMost(Duration.ofSeconds(60))
125+
.pollDelay(Duration.ofSeconds(1))
126+
.until(() -> output.getOut().contains("ConfigMap right-configmap was updated in namespace right"));
127+
128+
await().atMost(Duration.ofSeconds(60))
129+
.pollDelay(Duration.ofSeconds(1))
130+
.until(() -> output.getOut().contains("data in configmap has not changed, will not reload"));
131+
132+
// then deploy a new version of right-configmap, that actually changes some data
113133
ConfigMap rightConfigMapAfterChange = new ConfigMapBuilder()
114134
.withMetadata(new ObjectMetaBuilder().withNamespace(RIGHT_NAMESPACE).withName("right-configmap").build())
115135
.withData(Map.of("right.value", "right-after-change"))

spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-fabric8-client-reload/src/test/java/org/springframework/cloud/kubernetes/fabric8/client/reload/Fabric8EventReloadDataChangesInConfigMapIT.java

Lines changed: 0 additions & 136 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"logging.level.org.springframework.cloud.kubernetes.fabric8.config.reload=debug",
5353
"spring.cloud.kubernetes.client.namespace=default" })
5454
@ActiveProfiles("with-secret")
55-
class Fabric8EventReloadSecretIT extends Fabric8EventReloadBase {
55+
class Fabric8EventReloadSecretConfigDataIT extends Fabric8EventReloadBase {
5656

5757
private static final String NAMESPACE = "default";
5858

0 commit comments

Comments
 (0)