Skip to content

Commit e460c44

Browse files
committed
GH-1259 Fix formatting of previous commit
1 parent 4b0636f commit e460c44

File tree

3 files changed

+28
-32
lines changed

3 files changed

+28
-32
lines changed

spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/main/java/org/springframework/cloud/function/adapter/gcp/FunctionInvoker.java

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,11 @@
3333
import com.google.cloud.functions.HttpRequest;
3434
import com.google.cloud.functions.HttpResponse;
3535
import com.google.cloud.functions.RawBackgroundFunction;
36-
37-
import reactor.core.publisher.Flux;
38-
3936
import org.apache.commons.logging.Log;
4037
import org.apache.commons.logging.LogFactory;
4138
import org.reactivestreams.Publisher;
39+
import reactor.core.publisher.Flux;
40+
4241
import org.springframework.boot.SpringApplication;
4342
import org.springframework.boot.WebApplicationType;
4443
import org.springframework.cloud.function.context.FunctionCatalog;
@@ -132,12 +131,7 @@ public void service(HttpRequest httpRequest, HttpResponse httpResponse) throws E
132131
Object resultObject = function.apply(message);
133132

134133
if (resultObject != null) {
135-
Message<?> result = null;
136-
if (resultObject instanceof Publisher<?>) {
137-
result = getResultFromPublisher(resultObject);
138-
} else {
139-
result = (Message<?>) resultObject;
140-
}
134+
Message<?> result = resultObject instanceof Publisher<?> ? getResultFromPublisher(resultObject) : (Message<?>) resultObject;
141135

142136
buildHttpResponse(httpRequest, httpResponse, result);
143137
}
@@ -163,7 +157,8 @@ public void accept(String json, Context context) {
163157
Message<byte[]> result = null;
164158
if (resultObject instanceof Publisher<?>) {
165159
result = getResultFromPublisher(resultObject);
166-
} else {
160+
}
161+
else {
167162
result = (Message<byte[]>) resultObject;
168163
}
169164

@@ -172,19 +167,19 @@ public void accept(String json, Context context) {
172167
}
173168
}
174169

175-
/**
176-
* This method build the http response from service
177-
*
178-
* @throws IOException
170+
/*
171+
* This method build the http response from service.
179172
*/
180173
private void buildHttpResponse(HttpRequest httpRequest, HttpResponse httpResponse, Message<?> result)
181174
throws IOException {
182175
MessageHeaders headers = result.getHeaders();
183176
if (result.getHeaders().containsKey(MessageHeaders.CONTENT_TYPE)) {
184177
httpResponse.setContentType(result.getHeaders().get(MessageHeaders.CONTENT_TYPE).toString());
185-
} else if (result.getHeaders().containsKey("Content-Type")) {
178+
}
179+
else if (result.getHeaders().containsKey("Content-Type")) {
186180
httpResponse.setContentType(result.getHeaders().get("Content-Type").toString());
187-
} else {
181+
}
182+
else {
188183
httpRequest.getContentType().ifPresent(contentType -> httpResponse.setContentType(contentType));
189184
}
190185
String content = result.getPayload() instanceof String strPayload ? strPayload
@@ -196,23 +191,25 @@ private void buildHttpResponse(HttpRequest httpRequest, HttpResponse httpRespons
196191
String headerValue = ((Collection<?>) values).stream().map(item -> item.toString())
197192
.collect(Collectors.joining(","));
198193
httpResponse.appendHeader(header.getKey(), headerValue);
199-
} else {
194+
}
195+
else {
200196
httpResponse.appendHeader(header.getKey(), header.getValue().toString());
201197
}
202198
}
203199

204200
if (headers.containsKey(HTTP_STATUS_CODE)) {
205201
if (headers.get(HTTP_STATUS_CODE) instanceof Integer) {
206202
httpResponse.setStatusCode((int) headers.get(HTTP_STATUS_CODE));
207-
} else {
203+
}
204+
else {
208205
log.warn("The statusCode should be an Integer value");
209206
}
210207
}
211208
}
212209

213-
/**
214-
* This methd get the result from reactor's publisher
215-
*
210+
/*
211+
* This methd get the result from reactor's publisher.
212+
*
216213
* For reference: https://github.com/spring-cloud/spring-cloud-function/blob/main/spring-cloud-function-adapters/spring-cloud-function-adapter-aws/src/main/java/org/springframework/cloud/function/adapter/aws/AWSLambdaUtils.java
217214
*/
218215
private Message<byte[]> getResultFromPublisher(Object resultObject) {
@@ -223,17 +220,20 @@ private Message<byte[]> getResultFromPublisher(Object resultObject) {
223220
if (item instanceof Message<?> messageItem) {
224221
results.add(convertFromJsonIfNecessary(messageItem.getPayload()));
225222
lastMessage = messageItem;
226-
} else {
223+
}
224+
else {
227225
results.add(convertFromJsonIfNecessary(item));
228226
}
229227
}
230228

231229
byte[] resultsPayload;
232230
if (results.size() == 1) {
233231
resultsPayload = jsonMapper.toJson(results.get(0));
234-
} else if (results.size() > 1) {
232+
}
233+
else if (results.size() > 1) {
235234
resultsPayload = jsonMapper.toJson(results);
236-
} else {
235+
}
236+
else {
237237
resultsPayload = null;
238238
}
239239

spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/test/java/org/springframework/cloud/function/adapter/gcp/FunctionInvokerBackgroundTests.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,10 @@
2222

2323
import com.github.blindpirate.extensions.CaptureSystemOutput;
2424
import com.google.gson.Gson;
25-
26-
import reactor.core.publisher.Flux;
27-
import reactor.core.publisher.Mono;
28-
2925
import org.hamcrest.Matchers;
3026
import org.junit.jupiter.api.Test;
27+
import reactor.core.publisher.Flux;
28+
import reactor.core.publisher.Mono;
3129

3230
import org.springframework.cloud.function.context.config.ContextFunctionCatalogAutoConfiguration;
3331
import org.springframework.cloud.function.json.JsonMapper;

spring-cloud-function-adapters/spring-cloud-function-adapter-gcp/src/test/java/org/springframework/cloud/function/adapter/gcp/FunctionInvokerHttpTests.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,12 @@
3030
import com.google.cloud.functions.HttpRequest;
3131
import com.google.cloud.functions.HttpResponse;
3232
import com.google.gson.Gson;
33-
34-
import reactor.core.publisher.Flux;
35-
import reactor.core.publisher.Mono;
36-
3733
import org.junit.jupiter.api.BeforeEach;
3834
import org.junit.jupiter.api.Test;
3935
import org.junit.jupiter.api.extension.ExtendWith;
4036
import org.mockito.Mockito;
37+
import reactor.core.publisher.Flux;
38+
import reactor.core.publisher.Mono;
4139

4240
import org.springframework.boot.test.system.CapturedOutput;
4341
import org.springframework.boot.test.system.OutputCaptureExtension;

0 commit comments

Comments
 (0)