Skip to content

Conversation

@pieninck
Copy link

fixes #2392

fixes spring-cloud#2392

Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
@marcingrzejszczak
Copy link
Contributor

I wonder how to test this. The only thing that comes to my mind is for now a unit test that would literally check if those strings are FQN of classes taken from the classpath. We have the classes on the classpath already, if we extract the strings into constants we could unit test if those constants are equal to FQN of org.eclipse.aether.transport.http.HttpTransporterFactory.class . That way we will ensure that no typos are present. WDYT?

@pieninck
Copy link
Author

This means that spelling mistakes are at least immediately noticeable. I will extract the strings into constants and add tests to check them against the FQN.

fixes spring-cloud#2392

Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
@pieninck
Copy link
Author

I tried to implement your suggestion of extracting and testing the fqn. Since it was my first commit to a spring project, please let me know if anything is missing.

fixes spring-cloud#2392

Signed-off-by: Jan-Niklas Pieninck <jan-niklas@pieninck.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optional provider not found on classpath: org.eclipse.aether.transport.http.HttpTransporterFanewRepositorySystemctory

3 participants