Use lb scheme to find the baseUrls for load-balancing.
#1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
ryanjbaxter
reviewed
May 19, 2025
| @@ -71,12 +72,16 @@ public void configureGroups(@NonNull Groups<RestClient.Builder> groups) { | |||
| groups.configureClient((group, builder) -> { | |||
| String groupName = group.name(); | |||
| HttpClientServiceProperties.Group groupProperties = clientServiceProperties.getGroup().get(groupName); | |||
| if (groupProperties == null || groupProperties.getBaseUrl() == null) { | |||
| String baseUrlString = groupProperties == null ? null : groupProperties.getBaseUrl(); | |||
| URI existingBaseUrl = baseUrlString == null ? null : URI.create(baseUrlString); | |||
There was a problem hiding this comment.
Seems like some of this logic could be simplified if you checked if baseUrlString == null
There was a problem hiding this comment.
Wanted to have a local variable to be able to use it later in the else if section: else if ("lb".equalsIgnoreCase(existingBaseUrl.getScheme()))
There was a problem hiding this comment.
Actually I think what would make this clearer would be to just simplify this to URI existingBaseUrl = groupProperties == null ? null : URI.create(groupProperties.getBaseUrl());
There was a problem hiding this comment.
groupProperties.getBaseUrl() can also be null.
spencergibb
approved these changes
May 19, 2025
ryanjbaxter
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.