Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish note about @ConfigurationProperties can't be refreshed #1466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Polish note about @ConfigurationProperties can't be refreshed #1466

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Feb 7, 2025

No description provided.

@spencergibb
Copy link
Member

Your change implies other types can't be refreshed. Can you describe why you want this change?

@quaff
Copy link
Contributor Author

quaff commented Feb 7, 2025

Your change implies other types can't be refreshed. Can you describe why you want this change?

My point is not only Java Records but any type using constructor binding.

See https://github.com/spring-projects/spring-boot/blob/1e73a7cf8b376ea4b5ead9e56df093e5354c4de7/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/properties/bind/BindMethod.java#L33C18-L33C43

@spencergibb
Copy link
Member

Then say that rather than value object.

spencergibb
spencergibb requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change value object to something about constructor binding.

@quaff
Polish note about @ConfigurationProperties can't be refreshed.
33b6761 
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@quaff
Copy link
Contributor Author

quaff commented Feb 8, 2025

I copied terms from Javadoc of Spring Boot, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencergibb spencergibb spencergibb requested changes

Assignees
No one assigned
Labels
waiting for feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @spencergibb @spring-cloud-issues