Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.
This repository was archived by the owner on May 14, 2025. It is now read-only.

The local storage check for the Reverse-Proxy-Feature is made against boolean not string #2015

Open
@klopfdreh

Description

@klopfdreh

We updated to SCDF 2.11.5 and there was a small mistake I made for the check if the Reverse-Proxy-Feature is enabled.

See: https://github.com/spring-cloud/spring-cloud-dataflow-ui/blob/v3.4.6/ui/src/app/shared/api/task.service.ts#L269

it should be

UrlUtilities.fixReverseProxyUrl(url, this.localStorageService.get('reverseProxyFixActiveValue') === 'true'),

I am going to create a fix PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    status/need-triageTeam needs to triage and take a first look

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions