Comment Parser#48
Merged
mikehadlow merged 4 commits intosprache:masterfrom Jan 21, 2015
IanWold:Comments
Merged
Conversation
Added CommentParser class to construct custom single and multi-line comment parsers. * Updated AssemblerTests.cs to use new CommentParser class. * Removed EndOfLineComment in Parse.Primitives.cs
Creates an interface for CommentParser.
Adds comments to XmlExample to demonstrate CommentParser class.
|
This is pretty cool. For single line comments I note that a number of languages have multiple characters (I've dealt with some that have # and "//" for example). Could that be made an array? The other approach is to have a set of primitives that take the comment as an argument... so, for example, or similar. |
Collaborator
|
Many thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to share my solution to the problem discussed in this issue regarding comment parsing. I created this CommentParser class, which provides the user with a few comment parsers which will work with whichever headers they require. I removed the EndOfLineComment parser in Parse.Primitives.cs (as this CommentParser class achieves the same goal), and updated AssemblerTests to use the CommentParser class instead of that EndOfLineComment parser. I also modified the Xml Example to parse and ignore comments using CommentParser, so as to demonstrate the use of the class.