Merge pull request #30 from spotlibs/feature/exploration

dtos filter array key by properties

Author: m45adiwinata

src/Dtos/TraitConvertibleDtos.php

@@ -40,14 +40,16 @@ public function __construct(array $data = [])
     {
         $reflector = new ReflectionClass(static::class);
         foreach ($data as $key => $value) {
-            try {
-                $prop = $reflector->getProperty($key);
-            } catch (Throwable) {
-                // array key is not one of constructed DTO's property name
-                continue;
+            if (property_exists($this, $key)) {
+                try {
+                    $prop = $reflector->getProperty($key);
+                } catch (Throwable) {
+                    // array key is not one of constructed DTO's property name
+                    continue;
+                }
+                $value = TypeConverter::assertType($value, $reflector, $prop);
+                $this->{$key} = $value;
             }
-            $value = TypeConverter::assertType($value, $reflector, $prop);
-            $this->{$key} = $value;
         }
     }
 

src/Dtos/TraitDtos.php

@@ -39,15 +39,17 @@ public function __construct(array $data = [])
     {
         $reflector = new ReflectionClass(static::class);
         foreach ($data as $key => $value) {
-            if (is_array($value)) {
-                $prop = $reflector->getProperty($key);
-                $type = $prop->getType()->getName();
-                //construct object if type is not array
-                if ($type != 'array') {
-                    $value = new $type($value);
+            if (property_exists($this, $key)) {
+                if (is_array($value)) {
+                    $prop = $reflector->getProperty($key);
+                    $type = $prop->getType()->getName();
+                    //construct object if type is not array
+                    if ($type != 'array') {
+                        $value = new $type($value);
+                    }
                 }
+                $this->{$key} = $value;
             }
-            $this->{$key} = $value;
         }
     }
 

tests/Dtos/DtosTest.php

@@ -171,6 +171,7 @@ public function testDtoNestedArray(): void
             'name' => 'Bruce',
             'employeeId' => 1,
             'isActive' => true,
+            'friend' => 'Yuri',
             'relatives' => ['robert', 'lana', 'garry'],
             'partner' => [
                 'name' => 'Amanda',