System property http.nonProxyHosts is not processed properly

[alrega]

BUG REPORT:

Description

In case system property http.nonProxyHosts specified like -Dhttp.nonProxyHosts=site1|site2|ipmask1|ipmask2|etc it's processed properly. However in case it's specified using quoted string like -Dhttp.nonProxyHosts="site1|site2|ipmask1|ipmask2|etc", method com.spotify.docker.client.DefaultDockerClient#updateProxy parses the property into the following collection internally:

• "site1
• site2
• ipmask1
• ipmask2
• etc"
  So site1 and etc are not matched as sites with non-proxy connection

How to reproduce

java -Dhttp.proxyHost= -Dhttp.proxyPort= -Dhttp.nonProxyHosts="127.0.0.1|localhost" -jar java-application-that-uses-docker-client-which-connects-to-localhost-via-http.jar ...

What do you expect

ClientConfig is set up to use direct connection

What happened instead

ClientConfig is set up to use proxy, because localhost doesn't match localhost"

Software:

• docker version: N/A
• Spotify's docker-client version: 8.11.7

Full backtrace

N/A

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[alrega]

@davidxia , could you merge PR #1119 ?
Thanks.