feat: Remove Java-based Local OpenFeature Provider #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
force-pushed
the
remove-native-local
branch
2 times, most recently
from
e1168b2 to
e53a4f5
Compare
fabriziodemaria
commented
Oct 13, 2025
Comment on lines
+49
to
+61
| static ManagedChannel createConfidenceChannel() { | ||
| final String confidenceDomain = | ||
| Optional.ofNullable(System.getenv("CONFIDENCE_DOMAIN")).orElse(CONFIDENCE_DOMAIN); | ||
| final boolean useGrpcPlaintext = | ||
| Optional.ofNullable(System.getenv("CONFIDENCE_GRPC_PLAINTEXT")) | ||
| .map(Boolean::parseBoolean) | ||
| .orElse(false); | ||
| ManagedChannelBuilder<?> builder = ManagedChannelBuilder.forTarget(confidenceDomain); | ||
| if (useGrpcPlaintext) { | ||
| builder = builder.usePlaintext(); | ||
| } | ||
| return builder.intercept(new DefaultDeadlineClientInterceptor(Duration.ofMinutes(1))).build(); | ||
| } |
Member
Author
There was a problem hiding this comment.
Just unifying a code duplication
fabriziodemaria
force-pushed
the
remove-native-local
branch
from
e53a4f5 to
58ee3d2
Compare
fabriziodemaria
force-pushed
the
remove-native-local
branch
from
ff89352 to
2843761
Compare
nicklasl
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blessed solution being the WASM-based one, this PR aims at reduce unnecessary duplicated logic and streamline codebase maintenance and clarity.
Most of the edits are simple deletions, apart from a small refactoring related to logical expressions implementations that are moved to a dedicated sub-package to keep the codebase more tidy and easier to navigate